Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core][compiled graphs] Fix test_torch_tensor_dag_gpu CI failure #48204

Merged
merged 3 commits into from
Oct 23, 2024

Conversation

ruisearch42
Copy link
Contributor

@ruisearch42 ruisearch42 commented Oct 22, 2024

Why are these changes needed?

This PR fixes test_torch_tensor_dag_gpu with the following quick patches:

  1. Revert [core][aDAG] Clean up shutdown path #47702 , otherwise there is segfault
  2. Move TestNcclGroup as an inner class for the tests, otherwise there are the following error:
(TorchTensorWorker pid=2261373) No module named 'test_torch_tensor_dag'
(TorchTensorWorker pid=2261373) Traceback (most recent call last):
(TorchTensorWorker pid=2261373)   File "/home/ubuntu/ray/python/ray/_private/serialization.py", line 460, in deserialize_objects
(TorchTensorWorker pid=2261373)     obj = self._deserialize_object(data, metadata, object_ref)
(TorchTensorWorker pid=2261373)   File "/home/ubuntu/ray/python/ray/_private/serialization.py", line 317, in _deserialize_object
(TorchTensorWorker pid=2261373)     return self._deserialize_msgpack_data(data, metadata_fields)
(TorchTensorWorker pid=2261373)   File "/home/ubuntu/ray/python/ray/_private/serialization.py", line 272, in _deserialize_msgpack_data
(TorchTensorWorker pid=2261373)     python_objects = self._deserialize_pickle5_data(pickle5_data)
(TorchTensorWorker pid=2261373)   File "/home/ubuntu/ray/python/ray/_private/serialization.py", line 262, in _deserialize_pickle5_data
(TorchTensorWorker pid=2261373)     obj = pickle.loads(in_band)
(TorchTensorWorker pid=2261373) ModuleNotFoundError: No module named 'test_torch_tensor_dag'

We will investigate further for better fixes.

Related issue number

Closes #45920

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Ubuntu added 2 commits October 22, 2024 15:53
Signed-off-by: Rui Qiao <[email protected]>
@ruisearch42 ruisearch42 added the go add ONLY when ready to merge, run all tests label Oct 22, 2024
@stephanie-wang stephanie-wang enabled auto-merge (squash) October 22, 2024 23:04
@aslonnie aslonnie merged commit 23bb654 into ray-project:master Oct 23, 2024
4 of 5 checks passed
rkooo567 added a commit to rkooo567/ray that referenced this pull request Oct 24, 2024
stephanie-wang pushed a commit that referenced this pull request Oct 25, 2024
Jay-ju pushed a commit to Jay-ju/ray that referenced this pull request Nov 5, 2024
…-project#48204)

## Why are these changes needed?

This PR fixes test_torch_tensor_dag_gpu with the following quick patches:
1. Revert ray-project#47702 , otherwise there is segfault
2. Move TestNcclGroup as an inner class for the tests, otherwise there are the following error:

```
(TorchTensorWorker pid=2261373) No module named 'test_torch_tensor_dag'
(TorchTensorWorker pid=2261373) Traceback (most recent call last):
(TorchTensorWorker pid=2261373)   File "/home/ubuntu/ray/python/ray/_private/serialization.py", line 460, in deserialize_objects
(TorchTensorWorker pid=2261373)     obj = self._deserialize_object(data, metadata, object_ref)
(TorchTensorWorker pid=2261373)   File "/home/ubuntu/ray/python/ray/_private/serialization.py", line 317, in _deserialize_object
(TorchTensorWorker pid=2261373)     return self._deserialize_msgpack_data(data, metadata_fields)
(TorchTensorWorker pid=2261373)   File "/home/ubuntu/ray/python/ray/_private/serialization.py", line 272, in _deserialize_msgpack_data
(TorchTensorWorker pid=2261373)     python_objects = self._deserialize_pickle5_data(pickle5_data)
(TorchTensorWorker pid=2261373)   File "/home/ubuntu/ray/python/ray/_private/serialization.py", line 262, in _deserialize_pickle5_data
(TorchTensorWorker pid=2261373)     obj = pickle.loads(in_band)
(TorchTensorWorker pid=2261373) ModuleNotFoundError: No module named 'test_torch_tensor_dag'
```
Jay-ju pushed a commit to Jay-ju/ray that referenced this pull request Nov 5, 2024
JP-sDEV pushed a commit to JP-sDEV/ray that referenced this pull request Nov 14, 2024
…-project#48204)

## Why are these changes needed?

This PR fixes test_torch_tensor_dag_gpu with the following quick patches:
1. Revert ray-project#47702 , otherwise there is segfault
2. Move TestNcclGroup as an inner class for the tests, otherwise there are the following error:

```
(TorchTensorWorker pid=2261373) No module named 'test_torch_tensor_dag'
(TorchTensorWorker pid=2261373) Traceback (most recent call last):
(TorchTensorWorker pid=2261373)   File "/home/ubuntu/ray/python/ray/_private/serialization.py", line 460, in deserialize_objects
(TorchTensorWorker pid=2261373)     obj = self._deserialize_object(data, metadata, object_ref)
(TorchTensorWorker pid=2261373)   File "/home/ubuntu/ray/python/ray/_private/serialization.py", line 317, in _deserialize_object
(TorchTensorWorker pid=2261373)     return self._deserialize_msgpack_data(data, metadata_fields)
(TorchTensorWorker pid=2261373)   File "/home/ubuntu/ray/python/ray/_private/serialization.py", line 272, in _deserialize_msgpack_data
(TorchTensorWorker pid=2261373)     python_objects = self._deserialize_pickle5_data(pickle5_data)
(TorchTensorWorker pid=2261373)   File "/home/ubuntu/ray/python/ray/_private/serialization.py", line 262, in _deserialize_pickle5_data
(TorchTensorWorker pid=2261373)     obj = pickle.loads(in_band)
(TorchTensorWorker pid=2261373) ModuleNotFoundError: No module named 'test_torch_tensor_dag'
```

Signed-off-by: JP-sDEV <[email protected]>
JP-sDEV pushed a commit to JP-sDEV/ray that referenced this pull request Nov 14, 2024
mohitjain2504 pushed a commit to mohitjain2504/ray that referenced this pull request Nov 15, 2024
…-project#48204)

## Why are these changes needed?

This PR fixes test_torch_tensor_dag_gpu with the following quick patches:
1. Revert ray-project#47702 , otherwise there is segfault
2. Move TestNcclGroup as an inner class for the tests, otherwise there are the following error:

```
(TorchTensorWorker pid=2261373) No module named 'test_torch_tensor_dag'
(TorchTensorWorker pid=2261373) Traceback (most recent call last):
(TorchTensorWorker pid=2261373)   File "/home/ubuntu/ray/python/ray/_private/serialization.py", line 460, in deserialize_objects
(TorchTensorWorker pid=2261373)     obj = self._deserialize_object(data, metadata, object_ref)
(TorchTensorWorker pid=2261373)   File "/home/ubuntu/ray/python/ray/_private/serialization.py", line 317, in _deserialize_object
(TorchTensorWorker pid=2261373)     return self._deserialize_msgpack_data(data, metadata_fields)
(TorchTensorWorker pid=2261373)   File "/home/ubuntu/ray/python/ray/_private/serialization.py", line 272, in _deserialize_msgpack_data
(TorchTensorWorker pid=2261373)     python_objects = self._deserialize_pickle5_data(pickle5_data)
(TorchTensorWorker pid=2261373)   File "/home/ubuntu/ray/python/ray/_private/serialization.py", line 262, in _deserialize_pickle5_data
(TorchTensorWorker pid=2261373)     obj = pickle.loads(in_band)
(TorchTensorWorker pid=2261373) ModuleNotFoundError: No module named 'test_torch_tensor_dag'
```

Signed-off-by: mohitjain2504 <[email protected]>
mohitjain2504 pushed a commit to mohitjain2504/ray that referenced this pull request Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go add ONLY when ready to merge, run all tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI test linux://python/ray/dag:test_torch_tensor_dag_gpu is flaky
3 participants