-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[core][compiled graphs] Fix test_torch_tensor_dag_gpu CI failure #48204
Merged
aslonnie
merged 3 commits into
ray-project:master
from
ruisearch42:revert_adag_teardown
Oct 23, 2024
Merged
[core][compiled graphs] Fix test_torch_tensor_dag_gpu CI failure #48204
aslonnie
merged 3 commits into
ray-project:master
from
ruisearch42:revert_adag_teardown
Oct 23, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit bc99a3b. Signed-off-by: Rui Qiao <[email protected]>
Signed-off-by: Rui Qiao <[email protected]>
ruisearch42
force-pushed
the
revert_adag_teardown
branch
from
October 22, 2024 22:53
940b5a7
to
dab4b89
Compare
stephanie-wang
approved these changes
Oct 22, 2024
rkooo567
added a commit
to rkooo567/ray
that referenced
this pull request
Oct 24, 2024
…ure (ray-project#48204)" This reverts commit 23bb654.
8 tasks
stephanie-wang
pushed a commit
that referenced
this pull request
Oct 25, 2024
Jay-ju
pushed a commit
to Jay-ju/ray
that referenced
this pull request
Nov 5, 2024
…-project#48204) ## Why are these changes needed? This PR fixes test_torch_tensor_dag_gpu with the following quick patches: 1. Revert ray-project#47702 , otherwise there is segfault 2. Move TestNcclGroup as an inner class for the tests, otherwise there are the following error: ``` (TorchTensorWorker pid=2261373) No module named 'test_torch_tensor_dag' (TorchTensorWorker pid=2261373) Traceback (most recent call last): (TorchTensorWorker pid=2261373) File "/home/ubuntu/ray/python/ray/_private/serialization.py", line 460, in deserialize_objects (TorchTensorWorker pid=2261373) obj = self._deserialize_object(data, metadata, object_ref) (TorchTensorWorker pid=2261373) File "/home/ubuntu/ray/python/ray/_private/serialization.py", line 317, in _deserialize_object (TorchTensorWorker pid=2261373) return self._deserialize_msgpack_data(data, metadata_fields) (TorchTensorWorker pid=2261373) File "/home/ubuntu/ray/python/ray/_private/serialization.py", line 272, in _deserialize_msgpack_data (TorchTensorWorker pid=2261373) python_objects = self._deserialize_pickle5_data(pickle5_data) (TorchTensorWorker pid=2261373) File "/home/ubuntu/ray/python/ray/_private/serialization.py", line 262, in _deserialize_pickle5_data (TorchTensorWorker pid=2261373) obj = pickle.loads(in_band) (TorchTensorWorker pid=2261373) ModuleNotFoundError: No module named 'test_torch_tensor_dag' ```
Jay-ju
pushed a commit
to Jay-ju/ray
that referenced
this pull request
Nov 5, 2024
ray-project#48250) …ure (ray-project#48204)" This reverts commit 23bb654. Revert revert of ray-project#47702.
JP-sDEV
pushed a commit
to JP-sDEV/ray
that referenced
this pull request
Nov 14, 2024
…-project#48204) ## Why are these changes needed? This PR fixes test_torch_tensor_dag_gpu with the following quick patches: 1. Revert ray-project#47702 , otherwise there is segfault 2. Move TestNcclGroup as an inner class for the tests, otherwise there are the following error: ``` (TorchTensorWorker pid=2261373) No module named 'test_torch_tensor_dag' (TorchTensorWorker pid=2261373) Traceback (most recent call last): (TorchTensorWorker pid=2261373) File "/home/ubuntu/ray/python/ray/_private/serialization.py", line 460, in deserialize_objects (TorchTensorWorker pid=2261373) obj = self._deserialize_object(data, metadata, object_ref) (TorchTensorWorker pid=2261373) File "/home/ubuntu/ray/python/ray/_private/serialization.py", line 317, in _deserialize_object (TorchTensorWorker pid=2261373) return self._deserialize_msgpack_data(data, metadata_fields) (TorchTensorWorker pid=2261373) File "/home/ubuntu/ray/python/ray/_private/serialization.py", line 272, in _deserialize_msgpack_data (TorchTensorWorker pid=2261373) python_objects = self._deserialize_pickle5_data(pickle5_data) (TorchTensorWorker pid=2261373) File "/home/ubuntu/ray/python/ray/_private/serialization.py", line 262, in _deserialize_pickle5_data (TorchTensorWorker pid=2261373) obj = pickle.loads(in_band) (TorchTensorWorker pid=2261373) ModuleNotFoundError: No module named 'test_torch_tensor_dag' ``` Signed-off-by: JP-sDEV <[email protected]>
JP-sDEV
pushed a commit
to JP-sDEV/ray
that referenced
this pull request
Nov 14, 2024
ray-project#48250) …ure (ray-project#48204)" This reverts commit 23bb654. Revert revert of ray-project#47702. Signed-off-by: JP-sDEV <[email protected]>
mohitjain2504
pushed a commit
to mohitjain2504/ray
that referenced
this pull request
Nov 15, 2024
…-project#48204) ## Why are these changes needed? This PR fixes test_torch_tensor_dag_gpu with the following quick patches: 1. Revert ray-project#47702 , otherwise there is segfault 2. Move TestNcclGroup as an inner class for the tests, otherwise there are the following error: ``` (TorchTensorWorker pid=2261373) No module named 'test_torch_tensor_dag' (TorchTensorWorker pid=2261373) Traceback (most recent call last): (TorchTensorWorker pid=2261373) File "/home/ubuntu/ray/python/ray/_private/serialization.py", line 460, in deserialize_objects (TorchTensorWorker pid=2261373) obj = self._deserialize_object(data, metadata, object_ref) (TorchTensorWorker pid=2261373) File "/home/ubuntu/ray/python/ray/_private/serialization.py", line 317, in _deserialize_object (TorchTensorWorker pid=2261373) return self._deserialize_msgpack_data(data, metadata_fields) (TorchTensorWorker pid=2261373) File "/home/ubuntu/ray/python/ray/_private/serialization.py", line 272, in _deserialize_msgpack_data (TorchTensorWorker pid=2261373) python_objects = self._deserialize_pickle5_data(pickle5_data) (TorchTensorWorker pid=2261373) File "/home/ubuntu/ray/python/ray/_private/serialization.py", line 262, in _deserialize_pickle5_data (TorchTensorWorker pid=2261373) obj = pickle.loads(in_band) (TorchTensorWorker pid=2261373) ModuleNotFoundError: No module named 'test_torch_tensor_dag' ``` Signed-off-by: mohitjain2504 <[email protected]>
mohitjain2504
pushed a commit
to mohitjain2504/ray
that referenced
this pull request
Nov 15, 2024
ray-project#48250) …ure (ray-project#48204)" This reverts commit 23bb654. Revert revert of ray-project#47702. Signed-off-by: mohitjain2504 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
This PR fixes test_torch_tensor_dag_gpu with the following quick patches:
We will investigate further for better fixes.
Related issue number
Closes #45920
Checks
git commit -s
) in this PR.scripts/format.sh
to lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/
under thecorresponding
.rst
file.