Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Namespace conf #116

Closed
wants to merge 85 commits into from
Closed
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
85 commits
Select commit Hold shift + click to select a range
ecf98ee
fix: kube deployment char limit
spy16 Mar 2, 2023
d48ba77
feat: add deployment_id feature
spy16 Mar 3, 2023
5d3d7ad
Merge pull request #1 from goto/fix/bugs
spy16 Mar 13, 2023
4867aa2
refactor: rename to goto (#2)
ishanarya0 Mar 14, 2023
3b338aa
fix: golanci config (#3)
ishanarya0 Mar 14, 2023
4d909e6
fix: kube config handling (#4)
spy16 Mar 15, 2023
e96dcf9
fix: deployment id name (#5)
spy16 Mar 15, 2023
202e4ad
Fix/generic (#6)
spy16 Mar 16, 2023
e758108
fix: change odpf reference to goto (#7)
ishanarya0 Mar 16, 2023
26d5226
generic refactors (#8)
spy16 Mar 17, 2023
ab5b2dc
fix: firehose image name (#9)
spy16 Mar 17, 2023
022f7a4
refactor: re-implement firehose module (#10)
spy16 Mar 21, 2023
4b6a238
fix: use previous telegraf conf (#11)
spy16 Mar 21, 2023
152a191
fix: length validation issue (#12)
spy16 Mar 21, 2023
f66d8bf
fix: goreleaser commit author (#14)
ishanarya0 Mar 24, 2023
fade8c7
feat: add stop flag support (#13)
spy16 Mar 24, 2023
226fd7f
feat: add stop flag support (#13) (#15)
spy16 Mar 25, 2023
cffb11f
fix: revision listing db query (#16)
spy16 Mar 27, 2023
b93cbb8
fix: expose chart values type (#17)
spy16 Mar 27, 2023
b063bba
feat: strip trailing colon in image tag, add telegraf config template
spy16 Mar 30, 2023
fb2202d
fix: telegraf config format (#19)
spy16 Mar 30, 2023
eacb30f
feat: add support for dynamic telegraf labels (#20)
spy16 Mar 30, 2023
9a37814
fix: use go map for telegraf image spec (#21)
spy16 Mar 30, 2023
52671a6
fix: use map to fix yaml marshal (#22)
spy16 Mar 30, 2023
2b799d7
fix: set deployment-id length limit as 63 (#23)
spy16 Mar 30, 2023
3a368d2
fix: revert 63 limit to 53 due helm limitation (#24)
spy16 Mar 30, 2023
d3e42c0
feat: refactor release name to be consistent with old format (#25)
spy16 Mar 30, 2023
cbc5e88
fix: helm release name limit (#26)
spy16 Mar 30, 2023
dc4b7ca
feat: implement deployment label templating (#27)
spy16 Apr 3, 2023
199def5
fix: expose name in firehose module (#28)
spy16 Apr 4, 2023
00fc0d6
refactor: simplify helm package (#29)
spy16 Apr 5, 2023
a354d34
feat: add labels to list-resource api (#30)
spy16 Apr 5, 2023
84ec3cc
feat: merge action and existing labels (#31)
spy16 Apr 6, 2023
4538cb7
fix: remove name label to prevent length issues (#32)
spy16 Apr 6, 2023
71766cb
feat: add jdbc sink type (#33)
ishanarya0 Apr 11, 2023
4e03452
feat: allow custom usage for each firehose (#34)
ishanarya0 Apr 12, 2023
b013688
feat: add tolerations feature (#35)
spy16 Apr 18, 2023
a5f3898
fix: move volume values outside firehose key (#36)
spy16 Apr 21, 2023
d3193e7
fix: add secret key (#37)
ishanarya0 Apr 21, 2023
0919cc5
feat: add toleration to kube module config (#38)
ishanarya0 Apr 27, 2023
74d17e4
feat: add support for sink specific requests & limits (#39)
spy16 May 9, 2023
7e4caa7
feat: add firehose base config (#40)
ishanarya0 May 17, 2023
57a30e8
feat: offset reset history (#42)
ishanarya0 Jul 17, 2023
0128a81
feat: add statsd variables to envVariables (#41)
ishanarya0 Jul 17, 2023
e54c6f9
fix: goreleaser action upgrade (#43)
ishanarya0 Jul 17, 2023
272eb86
fix: change rm-dist flag to clean (#44)
ishanarya0 Jul 17, 2023
1538c02
fix: goreleaser (#45)
ishanarya0 Jul 17, 2023
f3642c1
feat: stoptime in firehose start (#46)
ishanarya0 Jul 19, 2023
cadc134
refactor: public ScaleParams & StartParams (#47)
ishanarya0 Jul 25, 2023
2217ff1
feat: add urn to deployment labels (#48)
ishanarya0 Jul 26, 2023
178f6a8
feat: createdBy and updatedBy in resource & revision (#49)
ishanarya0 Jul 27, 2023
178e82c
feat: broaden AdditionalGlobalTags scope (#50)
ishanarya0 Jul 27, 2023
aac1e7f
fix: initialize as empty arrays (#51)
ishanarya0 Jul 28, 2023
0cb3d28
feat: firehose update to take the latest driver configs (#52)
ishanarya0 Jul 31, 2023
b66407d
fix: update stopped status (#53)
ishanarya0 Aug 7, 2023
01dc9fe
feat: add logging request body (#54)
ishanarya0 Aug 16, 2023
b58f67f
feat: mounts as secrets (#55)
ishanarya0 Aug 21, 2023
43d5983
fix: mount secrets (#56)
ishanarya0 Aug 21, 2023
63bc82b
fix: key name (#57)
ishanarya0 Aug 21, 2023
198c661
fix: add bigtable cred path (#58)
ishanarya0 Aug 24, 2023
e0da338
fix: remove skipping empty values for env variables (#59)
ishanarya0 Aug 24, 2023
bc5e389
fix: mount path to be independent of dep id (#60)
ishanarya0 Aug 28, 2023
4397eb2
feat: return only running & non-terminating pods (#61)
ishanarya0 Aug 30, 2023
305fb47
feat: get resource to persist output (#62)
ishanarya0 Aug 30, 2023
f82209f
feat: add name as extra label (#64)
ishanarya0 Aug 31, 2023
32547ef
feat: support google service account for gke usage (#63)
mabdh Sep 4, 2023
851bee4
test: payloads sent to LOG, BQ and GCS/BLOB sinks (#66)
ishanarya0 Sep 7, 2023
4137fee
fix: add delay before executing reset (#69)
ishanarya0 Sep 11, 2023
9773fcd
fix: job name should be within 63 char limit (#70)
ishanarya0 Sep 14, 2023
ee9a105
fix: remove -firehose from job name (#71)
ishanarya0 Sep 14, 2023
2c4ef1f
feat: old reset strategy (#72)
ishanarya0 Sep 20, 2023
4fdfd50
fix: empty body while logging (#67)
ishanarya0 Sep 21, 2023
876f246
feat: add global logger (#75)
lavkesh Sep 27, 2023
e6b56cc
feat: add global logger (#76)
lavkesh Sep 27, 2023
f0f1a8c
feat: adding job module (#74)
lavkesh Sep 29, 2023
44b26ce
feat: add shared volume (#77)
lavkesh Oct 3, 2023
0afa18d
fead: add sequence if group id does not have it (#73)
ishanarya0 Oct 4, 2023
11a3627
feat: output refresh and logs for job module (#78)
lavkesh Oct 4, 2023
b0bff0f
fix: init container issue (#79)
ishanarya0 Oct 6, 2023
8222c63
feat: on delete cascade in tags table (#80)
ishanarya0 Oct 9, 2023
ae35b4b
feat: add joins in list query (#82)
ishanarya0 Oct 12, 2023
76eba64
feat: optional spec configs (#83)
ishanarya0 Oct 13, 2023
4d0e906
fix: allow overiding user passed resource & limits (#84)
ishanarya0 Oct 20, 2023
47a6094
chore: if namespace is empty take from default
lavkesh Oct 24, 2023
048f458
fix: do not overwrite the namespace
lavkesh Nov 22, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fix: do not overwrite the namespace
  • Loading branch information
lavkesh committed Nov 22, 2023
commit 048f458fc62efdc1755d85e50cc3d1e4304a726b
4 changes: 1 addition & 3 deletions modules/firehose/driver_plan.go
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,7 @@ import (

const SourceKafkaConsumerAutoOffsetReset = "SOURCE_KAFKA_CONSUMER_CONFIG_AUTO_OFFSET_RESET"

var (
suffixRegex = regexp.MustCompile(`^([A-Za-z0-9-]+)-([0-9]+)$`)
)
var suffixRegex = regexp.MustCompile(`^([A-Za-z0-9-]+)-([0-9]+)$`)

func (fd *firehoseDriver) Plan(_ context.Context, exr module.ExpandedResource, act module.ActionRequest) (*resource.Resource, error) {
switch act.Name {
Expand Down
1 change: 0 additions & 1 deletion modules/job/driver/plan.go
Original file line number Diff line number Diff line change
Expand Up @@ -38,8 +38,7 @@
return driver.planPendingWithConf(conf, exr, []PendingStep{Create})
}

func (driver *Driver) planPendingWithConf(conf *config.Config, exr module.ExpandedResource, steps []PendingStep) (*resource.Resource, error) {

Check failure on line 41 in modules/job/driver/plan.go

View workflow job for this annotation

GitHub Actions / golangci-lint

unused-receiver: method receiver 'driver' is not referenced in method's body, consider removing or renaming it as _ (revive)
conf.Namespace = driver.Conf.Namespace
immediately := time.Now()
exr.Resource.Spec.Configs = modules.MustJSON(conf)
exr.Resource.State = resource.State{
Expand Down
Loading