chore: remove empty fields

raystack · May 30, 2022 · 062956c · 062956c
1 parent 34a8450
commit 062956c
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 37 deletions.
diff --git a/plugins/extractors/shield/shield.go b/plugins/extractors/shield/shield.go
@@ -97,14 +97,10 @@ func (e *Extractor) Extract(ctx context.Context, emit plugins.Emit) error {
 				Type:        "user",
 				Description: user.GetSlug(),
 			},
-			Email:        user.GetEmail(),
-			Username:     user.GetId(),
-			FullName:     user.GetName(),
-			DisplayName:  "",
-			Title:        "",
-			Status:       "active",
-			ManagerEmail: "",
-			Profiles:     nil,
+			Email:    user.GetEmail(),
+			Username: user.GetId(),
+			FullName: user.GetName(),
+			Status:   "active",
 			Memberships: []*assetsv1beta1.Membership{
 				{
 					GroupUrn: fmt.Sprintf("%s:%s", grp.Group.GetName(), grp.Group.GetId()),
@@ -115,7 +111,6 @@ func (e *Extractor) Extract(ctx context.Context, emit plugins.Emit) error {
 				CreateTime: user.GetCreatedAt(),
 				UpdateTime: user.GetUpdatedAt(),
 			},
-			Event: nil,
 		}))
 	}
 

diff --git a/plugins/extractors/shield/shield_test.go b/plugins/extractors/shield/shield_test.go
@@ -143,55 +143,35 @@ func setupExtractExpectation(ctx context.Context, client *mockClient) {
 		Id: "user-A",
 	}, mock.Anything).Return(&sh.GetRoleResponse{
 		Role: &sh.Role{
-			Id:        "user-A",
-			Name:      "role-A",
-			Types:     nil,
-			Namespace: nil,
-			Metadata:  nil,
-			CreatedAt: nil,
-			UpdatedAt: nil,
+			Id:   "user-A",
+			Name: "role-A",
 		},
 	}, nil).Once()
 
 	client.On("GetRole", ctx, &sh.GetRoleRequest{
 		Id: "user-B",
 	}, mock.Anything).Return(&sh.GetRoleResponse{
 		Role: &sh.Role{
-			Id:        "user-B",
-			Name:      "role-B",
-			Types:     nil,
-			Namespace: nil,
-			Metadata:  nil,
-			CreatedAt: nil,
-			UpdatedAt: nil,
+			Id:   "user-B",
+			Name: "role-B",
 		},
 	}, nil).Once()
 
 	client.On("GetGroup", ctx, &sh.GetGroupRequest{
 		Id: "user-A",
 	}, mock.Anything).Return(&sh.GetGroupResponse{
 		Group: &sh.Group{
-			Id:        "grpId-A",
-			Name:      "grpname-A",
-			Slug:      "",
-			OrgId:     "",
-			Metadata:  nil,
-			CreatedAt: nil,
-			UpdatedAt: nil,
+			Id:   "grpId-A",
+			Name: "grpname-A",
 		},
 	}, nil).Once()
 
 	client.On("GetGroup", ctx, &sh.GetGroupRequest{
 		Id: "user-B",
 	}, mock.Anything).Return(&sh.GetGroupResponse{
 		Group: &sh.Group{
-			Id:        "grpId-B",
-			Name:      "grpname-B",
-			Slug:      "",
-			OrgId:     "",
-			Metadata:  nil,
-			CreatedAt: nil,
-			UpdatedAt: nil,
+			Id:   "grpId-B",
+			Name: "grpname-B",
 		},
 	}, nil).Once()
 }