Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support for version check using version package #5

Merged
merged 1 commit into from
Sep 6, 2021

Conversation

scortier
Copy link
Member

@scortier scortier commented Aug 25, 2021

Description

Adds a package to return the latest binary version .
Condition applied, if current binary version of user system is not upto date.

Related Issues

Issue #4

@ravisuhag
Copy link
Member

ravisuhag commented Aug 25, 2021

@scortier We also need to encapsulate storing of the current version, build, etc. in this package only. So the version package should also be able to return current version.

@scortier
Copy link
Member Author

@scortier We also need to encapsulate storing of the current version, build, etc. in this package only. So the version package should also be able to return me the current version.

Sure, will add this features too (WIP)

@scortier
Copy link
Member Author

scortier commented Aug 26, 2021

@scortier We also need to encapsulate storing of the current version, build, etc. in this package only. So the version package should also be able to return current version.

@ravisuhag Do we need to ask user for their current binary version or should the package itself need to find it ?

@ravisuhag
Copy link
Member

ravisuhag commented Aug 26, 2021

These vars can be at this package level only but we can expose a function for users to set them up. Package users can then maybe decide if they want to use go build flags to directly set up build and version or use the function to assign them.
Another way could be the version package expect users to send this explicitly.
WDYT?

version/check.go Outdated Show resolved Hide resolved
version/check.go Outdated Show resolved Hide resolved
version/check.go Outdated Show resolved Hide resolved
version/check.go Outdated Show resolved Hide resolved
@scortier
Copy link
Member Author

These vars can be at this package level only but we can expose a function for users to set them up. Package users can then maybe decide if they want to use go build flags to directly set up build and version or use the function to assign them.
Another way could be the version package expect users to send this explicitly.
WDYT?

Currently , moving forward with the approach of user providing the current version.

@scortier scortier force-pushed the version-check branch 2 times, most recently from 5354e5c to 0aff91d Compare August 30, 2021 07:13
version/check.go Outdated Show resolved Hide resolved
version/check.go Outdated Show resolved Hide resolved
go.mod Outdated Show resolved Hide resolved
version/check.go Outdated Show resolved Hide resolved
version/check.go Outdated Show resolved Hide resolved
@kushsharma kushsharma force-pushed the version-check branch 5 times, most recently from 52be2cf to c246195 Compare August 31, 2021 11:44
@rohilsurana rohilsurana self-requested a review September 1, 2021 08:50
version/release.go Outdated Show resolved Hide resolved
version/release.go Outdated Show resolved Hide resolved
@scortier scortier force-pushed the version-check branch 2 times, most recently from 06579d5 to 0c02378 Compare September 6, 2021 09:56
@ravisuhag
Copy link
Member

@scortier Can you fix the linting errors before we merge.

@ravisuhag ravisuhag merged commit 11ca0a8 into raystack:main Sep 6, 2021
@scortier scortier mentioned this pull request Sep 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants