[chore]: resolve review comments

razorpay · Jun 20, 2024 · 7288bfb · 7288bfb
1 parent 80a7be7
commit 7288bfb
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/packages/i18nify-js/src/modules/phoneNumber/__tests__/isValidPhoneNumber.test.ts b/packages/i18nify-js/src/modules/phoneNumber/__tests__/isValidPhoneNumber.test.ts
@@ -4,7 +4,7 @@ import { CountryCodeType } from '../../types';
 import { PhoneNumbersMockData } from '../types';
 
 describe('isValidPhoneNumber', () => {
-  describe('test using inhouse validator', () => {
+  describe('standard validity checks', () => {
     const validTestDataSet = [
       { countryCode: 'IN', phoneNumber: '+917394926646' },
       { countryCode: 'MY', phoneNumber: '+60123456789' },
@@ -60,11 +60,11 @@ describe('isValidPhoneNumber', () => {
     });
   });
 
-  describe('test via libphonenumber-js validator', () => {
+  describe('validation against known data sets from https://fakenumber.in/', () => {
     const phoneNumbersData: PhoneNumbersMockData =
       PHONE_NUMBERS_JSON as PhoneNumbersMockData;
     Object.keys(phoneNumbersData).forEach((countryCode) => {
-      it(`should match output with libphonenumber-js for ${countryCode}`, () => {
+      it(`should match output for ${countryCode}`, () => {
         phoneNumbersData[countryCode].forEach(
           (data: { PhoneNumber: string; isValid: boolean }) => {
             expect(