fix: text should be treated inValid in isValidPhoneNumber [ATLAS-196]

[RgnDunes]

Description

When you pass text say 'Contact Number' in isValidPhoneNumber it is being treated as valid contact number due to the fact that post cleaning phone number we get empty string in such cases which matches the regex leading to true value.

Changes Made

List the main changes made in this pull request.

Title	---
JIRA link	https://razorpay.atlassian.net/browse/ATLAS-196
Slack thread (if any)	NA
Product spec	NA
Tech spec/One-pager	NA
Bundle Size Difference	NA
Fixes Issue	NA

Type of change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update
• This change is a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

• Is your change backward compatible ?
• Tested on major browsers (Chrome, Firefox, Safari, IE) ?
• Tested in a consumer application(s) ?

Additional Notes

Any additional information that would be helpful for the reviewer.

Checklist:

• Add Jira ID(s) in PR title and in the description?
• I have performed a self-review of my code
• I have commented my code, particularly in hard-to-understand areas
• My code is written in TypeScript and follows the coding standards of the project.
• I have added relevant documentation and updated the README if necessary.
• My commit messages are clear and follow the project's commit message conventions.
• Is any external library added?
• My changes do not introduce any new runtime errors or warnings.
• All relevant unit tests have been added/updated in my PR for the change.
• Any Screenshots (mobile & desktop) required for PR? If yes, have you added the respective screenshots ?
• Any manual dev testing done by you on beta/func environment?
• Reviewer added (SLA 2 days)

Reviewer Checklist

• Sufficient QA/Dev-Testing is done with proof (test cases list)
• Ensure that the change in bundle size falls within the acceptable range.

---

PR Title Format

Format: <type>: <subject>

Types can be as follows:

• feat: (new feature for the user, not a new feature for build script)
• fix: (bug fix for the user, not a fix to a build script)
• docs: (changes to the documentation)
• style: (formatting, missing semi colons, etc; no production code change)
• refactor: (refactoring production code, eg. renaming a variable)
• test: (adding missing tests, refactoring tests; no production code change)
• chore: (updating grunt tasks etc; no production code change)

[changeset-bot]

🦋 Changeset detected

Latest commit: 5dece6b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@razorpay/i18nify-js	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[rzpcibot]

Bundle Size Report

Files

click to expand/collapse

🟢 No Change	🗑 File Deleted	🆕 New File	📈 Size Increased	👍 Size Reduced

		Parsed (kb)
🚦	File Name	Base	PR	Diff	%
📈	cjs/index.js	143.55	143.6	$\textcolor{red}{0.05}$	0.03
📈	esm/index.min.js	53.68	53.71	$\textcolor{red}{0.03}$	0.06
📈	umd/index.js	162.97	163.03	$\textcolor{red}{0.06}$	0.04

Generated by 🚫 dangerJS against 5dece6b

[github-actions]

Unit Test Results

0 files  0 suites   0s ⏱️
0 tests 0 ✔️ 0 💤 0 ❌

Results for commit 5dece6b.