Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: change flags name to lowercase in flags api #149

Merged
merged 23 commits into from
Jun 3, 2024
Merged

Conversation

RgnDunes
Copy link
Collaborator

@RgnDunes RgnDunes commented May 27, 2024

Description

This PR changes the country codes to lower case in flags api.

Changes Made

List the main changes made in this pull request.

Title ---
JIRA link NA
Slack thread (if any) NA
Product spec NA
Tech spec/One-pager NA
Bundle Size Difference NA
Fixes Issue NA

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • This change is a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Is your change backward compatible ?
  • Tested on major browsers (Chrome, Firefox, Safari, IE) ?
  • Tested in a consumer application(s) ?

Additional Notes

Any additional information that would be helpful for the reviewer.

Checklist:

  • Add Jira ID(s) in PR title and in the description?
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • My code is written in TypeScript and follows the coding standards of the project.
  • I have added relevant documentation and updated the README if necessary.
  • My commit messages are clear and follow the project's commit message conventions.
  • Is any external library added?
  • My changes do not introduce any new runtime errors or warnings.
  • All relevant unit tests have been added/updated in my PR for the change.
  • Any Screenshots (mobile & desktop) required for PR? If yes, have you added the respective screenshots ?
  • Any manual dev testing done by you on beta/func environment?
  • Reviewer added (SLA 2 days)

Reviewer Checklist

  • Sufficient QA/Dev-Testing is done with proof (test cases list)
  • Ensure that the change in bundle size falls within the acceptable range.

PR Title Format

Format: <type>: <subject>

Types can be as follows:

  • feat: (new feature for the user, not a new feature for build script)
  • fix: (bug fix for the user, not a fix to a build script)
  • docs: (changes to the documentation)
  • style: (formatting, missing semi colons, etc; no production code change)
  • refactor: (refactoring production code, eg. renaming a variable)
  • test: (adding missing tests, refactoring tests; no production code change)
  • chore: (updating grunt tasks etc; no production code change)

Sorry, something went wrong.

Copy link

changeset-bot bot commented May 27, 2024

🦋 Changeset detected

Latest commit: 5a821e8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@razorpay/i18nify-js Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

This comment has been minimized.

This comment has been minimized.

@rzpcibot
Copy link
Contributor

rzpcibot commented May 27, 2024

Warnings
⚠️ Your PR has over 600 lines of code additions 😱 . Try to breakup into separate PRs 👍

Bundle Size Report

Files

click to expand/collapse
🟢 No Change 🗑 File Deleted 🆕 New File 📈 Size Increased 👍 Size Reduced
Parsed (kb)
🚦 File Name Base PR Diff %
📈 cjs/index.js 146.22 147.04 0.82 0.56
📈 esm/index.min.js 52.8 53.32 0.52 0.98
📈 umd/index.js 166.76 167.81 1.05 0.63

Generated by 🚫 dangerJS against 5a821e8

This comment has been minimized.

@RgnDunes RgnDunes requested a review from tarun-khanna May 27, 2024 13:03

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

@codecov-commenter
Copy link

codecov-commenter commented May 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.53%. Comparing base (4d52f92) to head (5a821e8).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #149   +/-   ##
=======================================
  Coverage   96.52%   96.53%           
=======================================
  Files          48       48           
  Lines         662      663    +1     
  Branches      162      162           
=======================================
+ Hits          639      640    +1     
  Misses         23       23           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

@@ -662,7 +662,7 @@
"SGD": {
"name": "Singapore Dollar",
"minor_unit": "2",
"symbol": "$"
"symbol": "S$"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't change this right now.
This first needs to be consistent with all apis.. formatNumber, formatNumberByParts.. and others

"FW": "^\\+590\\s\\d{2}\\s\\d{2}\\s\\d{2}\\s\\d{2}$",
"YT-UNF": "^(?:\\+262)?\\d{9}$",
"TF": "",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happens in empty string regex ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Below are all the utilities that use this and their behaviours in such cases.

For such cases:

  1. isValidPhoneNumber

    • For phoneNumber = '', countryCode = 'UM', isValidPhoneNumber(phoneNumber, countryCode) returns false
    • For phoneNumber = '7394926646', countryCode = 'UM', isValidPhoneNumber(phoneNumber, countryCode) returns true
    • For phoneNumber = '+917394926646', countryCode = 'UM', isValidPhoneNumber(phoneNumber, countryCode) returns true
  2. detectCountryAndDialCodeFromPhone

    • no changes

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

@RgnDunes RgnDunes merged commit 6959a83 into master Jun 3, 2024
17 checks passed
@RgnDunes RgnDunes deleted the flags-case branch June 3, 2024 06:12
Copy link
Contributor

github-actions bot commented Jun 3, 2024

Unit Test Results

0 files  ±0  0 suites  ±0   0s ⏱️ ±0s
0 tests ±0  0 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 6959a83. ± Comparison against base commit 4d52f92.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants