Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct the url for flag images [Fixes #172] #173

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

fix: correct the url for flag images [Fixes #172] #173

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
3e0c7fb
fix: correct the url for flag images
sarthak-kumar-shailendra Oct 5, 2024
52d3a1a
Update phoneNumber-form.jsx
sarthak-kumar-shailendra Oct 11, 2024
fd9f464
correcting the url to avoid error
sarthak-kumar-shailendra Oct 11, 2024
35e5ea0
correcting the url to avoid error
sarthak-kumar-shailendra Oct 11, 2024
bf51faf
Update index.js
sarthak-kumar-shailendra Oct 17, 2024
e347a9c
Added cases to handle 001 and ac country code
sarthak-kumar-shailendra Oct 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions packages/i18nify-playground/src/constants/phoneNumber/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,3 +18,6 @@ export const PHONE_MASKING_INPUTS = [
type: 'number',
},
];

export const FLAG_CDN_BASE_PATH =
'https://flagcdn.com';
10 changes: 7 additions & 3 deletions packages/i18nify-playground/src/sections/phoneNumber/phoneNumber-form.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,8 @@ import {
localPhoneNumbersByDialCodeMap,
} from './data/phoneNumber';

import { FLAG_CDN_BASE_PATH } from 'src/constants/phoneNumber';

const PhoneNumberForm = ({
inpValue,
onInpChange,
Expand Down Expand Up @@ -88,9 +90,11 @@ const PhoneNumberForm = ({
marginRight: 8,
}}
loading="lazy"
src={`/assets/flags/${dialCodeCountryCodeMap[
code
][0].toLocaleLowerCase()}.svg`}
src={`${FLAG_CDN_BASE_PATH}/${
dialCodeCountryCodeMap[code][0].toLocaleLowerCase() === '001'? 'us' :
dialCodeCountryCodeMap[code][0].toLocaleLowerCase() === 'ac' ? 'sh' :
dialCodeCountryCodeMap[code][0].toLocaleLowerCase()
}.svg`}
/>
</Box>
</MenuItem>
Expand Down