You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added two ss to show of selecting different country.
List the main changes made in this pull request.
Title
---
JIRA link
NA
Slack thread (if any)
NA
Product spec
NA
Tech spec/One-pager
NA
Bundle Size Difference
NA
Fixes Issue
NA
Type of change
Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
This change requires a documentation update
This change is a documentation update
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Is your change backward compatible ?
Tested on major browsers (Chrome, Firefox, Safari, IE) ?
Tested in a consumer application(s) ?
Additional Notes
Any additional information that would be helpful for the reviewer.
Checklist:
Add Jira ID(s) in PR title and in the description?
I have performed a self-review of my code
I have commented my code, particularly in hard-to-understand areas
My code is written in TypeScript and follows the coding standards of the project.
I have added relevant documentation and updated the README if necessary.
My commit messages are clear and follow the project's commit message conventions.
Is any external library added?
My changes do not introduce any new runtime errors or warnings.
All relevant unit tests have been added/updated in my PR for the change.
Any Screenshots (mobile & desktop) required for PR? If yes, have you added the respective screenshots ?
Any manual dev testing done by you on beta/func environment?
Reviewer added (SLA 2 days)
Reviewer Checklist
Sufficient QA/Dev-Testing is done with proof (test cases list)
Ensure that the change in bundle size falls within the acceptable range.
PR Title Format
Format: <type>: <subject>
Types can be as follows:
feat: (new feature for the user, not a new feature for build script)
fix: (bug fix for the user, not a fix to a build script)
docs: (changes to the documentation)
style: (formatting, missing semi colons, etc; no production code change)
refactor: (refactoring production code, eg. renaming a variable)
test: (adding missing tests, refactoring tests; no production code change)
chore: (updating grunt tasks etc; no production code change)
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sarthak-kumar-shailendra
force-pushed
the
SKS/localeForAllCountries
branch
from
Description
Added locale of all the countries present in the database (https://github.com/razorpay/i18nify/blob/master/i18nify-data/country/metadata/data.json) and using the same values to create the LANGS array of obj. [Fixes #176]
Changes Made
Added two ss to show of selecting different country.
List the main changes made in this pull request.
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Additional Notes
Any additional information that would be helpful for the reviewer.
Checklist:
Reviewer Checklist
PR Title Format
Format:
<type>: <subject>Types can be as follows:
feat: (new feature for the user, not a new feature for build script)fix: (bug fix for the user, not a fix to a build script)docs: (changes to the documentation)style: (formatting, missing semi colons, etc; no production code change)refactor: (refactoring production code, eg. renaming a variable)test: (adding missing tests, refactoring tests; no production code change)chore: (updating grunt tasks etc; no production code change)