-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat : Add Currency Module : [ATLAS-26, ATLAS-27, ATLAS-28] #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RgnDunes
changed the title
feat : Add Currency Module :
feat : Add Currency Module : [ATLAS-26, ATLAS-27, ATLAS-28]
Oct 30, 2023
tarun-khanna
suggested changes
Oct 31, 2023
* add UT * remove window mock from test case * remove window mock from test case * fix failing test cases * fix failing test cases * fix failing test cases * fix failing test cases * Add UT for other currency functions * refactor test cases
tarun-khanna
reviewed
Nov 3, 2023
tarun-khanna
reviewed
Nov 3, 2023
tarun-khanna
reviewed
Nov 3, 2023
tarun-khanna
reviewed
Nov 3, 2023
tarun-khanna
suggested changes
Nov 8, 2023
Unit Test Results0 files 0 suites 0s ⏱️ Results for commit 7b1d35d. |
Bundle Size Report
|
🟢 No Change | 🗑 File Deleted | 🆕 New File | 📈 Size Increased | 👍 Size Reduced |
---|
Parsed (kb) | |||||
---|---|---|---|---|---|
🚦 | File Name | Base | PR | Diff | % |
📈 | cjs/index.js |
0.41 |
13.01 |
|
3073.17 |
📈 | esm/index.js |
0.39 |
12.99 |
|
3230.77 |
📈 | umd/index.js |
0.83 |
14.53 |
|
1650.6 |
tarun-khanna
reviewed
Nov 9, 2023
tarun-khanna
reviewed
Nov 9, 2023
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2 +/- ##
=========================================
Coverage ? 83.16%
=========================================
Files ? 13
Lines ? 101
Branches ? 28
=========================================
Hits ? 84
Misses ? 17
Partials ? 0 ☔ View full report in Codecov by Sentry. |
tarun-khanna
approved these changes
Nov 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds Currency module to the library.
Fixes # (issue)
Additional snippets: [Thread](Paste the thread link here....)
Jira/Asana
JIRA : https://razorpay.atlassian.net/browse/ATLAS-26, https://razorpay.atlassian.net/browse/ATLAS-27, https://razorpay.atlassian.net/browse/ATLAS-28
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist:
Reviewer Checklist