Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat]: validate github action added #9

Merged
merged 11 commits into from
Nov 7, 2023

Conversation

tarun-khanna
Copy link
Contributor

@tarun-khanna tarun-khanna commented Nov 2, 2023

Description

A new "validate" github action added for pull requests.
This github action will run the below tasks

  • run eslint: to ensure no code with eslint errors is merged to master
  • run tsc: to ensure code with proper types is merged to master
  • run build: to ensure we are able to create build successfully
Title ---
JIRA link https://razorpay.atlassian.net/browse/ATLAS-34
Slack thread (if any) NA
Product spec NA
Tech spec/One-pager NA
Bundle Size Difference NA

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Is your change backward compatible ?
  • Tested on major browsers (Chrome, Firefox, Safari, IE) ?
  • Tested in a consumer application(s) ?

Additional Notes

Any additional information that would be helpful for the reviewer.

Checklist:

  • Add Jira ID(s) in PR title and in the description?
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • My code is written in TypeScript and follows the coding standards of the project.
  • I have added relevant documentation and updated the README if necessary.
  • My commit messages are clear and follow the project's commit message conventions.
  • Is any external library added?
  • My changes do not introduce any new runtime errors or warnings.
  • All relevant unit tests have been added/updated in my PR for the change.
  • Any Screenshots (mobile & desktop) required for PR? If yes, have you added the respective screenshots ?
  • Any manual dev testing done by you on beta/func environment?
  • Reviewer added (SLA 2 days)

Reviewer Checklist

  • Sufficient QA/Dev-Testing is done with proof (test cases list)
  • Ensure that the change in bundle size falls within the acceptable range.

Copy link

@avinashdvv avinashdvv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly looks good, please address the comments

.github/workflows/validate.yml Show resolved Hide resolved
@avinashdvv avinashdvv dismissed their stale review November 7, 2023 09:05

I don't have proper knowledge on the github workflows process, due to this i am removing my comments.

Copy link
Collaborator

@RgnDunes RgnDunes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@tarun-khanna tarun-khanna merged commit 5749c90 into master Nov 7, 2023
2 checks passed
@tarun-khanna tarun-khanna deleted the feat/ValidateGithubAction branch November 7, 2023 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants