Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added document endpoint #271

Merged
merged 5 commits into from
Mar 19, 2024
Merged

Added document endpoint #271

merged 5 commits into from
Mar 19, 2024

Conversation

ankitdas13
Copy link
Contributor

@codecov-commenter
Copy link

codecov-commenter commented Mar 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.55%. Comparing base (5e828f4) to head (740a9e4).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #271      +/-   ##
==========================================
+ Coverage   97.06%   97.55%   +0.49%     
==========================================
  Files          62       64       +2     
  Lines        2009     2044      +35     
==========================================
+ Hits         1950     1994      +44     
+ Misses         59       50       -9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -53,5 +54,6 @@
'Stakeholder',
'Product',
'Iin',
'Webhook'
'Webhook',
'Document'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add , at the end

@@ -45,5 +46,6 @@
'Stakeholder',
'Product',
'Iin',
'Webhook'
'Webhook',
'Document'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add , at the end


def setUp(self):
super(TestClientDocument, self).setUp()
self.base_url = '{}/documents'.format(self.base_url)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we use string formater f'{self.base_url}/documents. Do the same across the PR

Copy link
Contributor

@razorpay-sanjib razorpay-sanjib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ankitdas13 ankitdas13 added the TestingNotRequired TestingNotRequired label for BVT label Mar 19, 2024
@ankitdas13 ankitdas13 merged commit e0cf503 into master Mar 19, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
TestingNotRequired TestingNotRequired label for BVT
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants