removed chaining

razorpay · May 27, 2024 · 3eaf6ba · 3eaf6ba
1 parent 01c60f5
commit 3eaf6ba
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 5 deletions.
diff --git a/documents/transfers.md b/documents/transfers.md
@@ -778,7 +778,7 @@ Razorpay::Transfer.fetch(transferId).edit(para_attr)
 ### Fetch Reversals for a Transfer
 ```rb
 transferId = "trf_JhemwjNekar9Za"
-Razorpay::Transfer.fetch(transferId).reversals
+Razorpay::Transfer.reversals(transferId)
 ```
 
 **Parameters:**

diff --git a/lib/razorpay/transfer.rb b/lib/razorpay/transfer.rb
@@ -32,8 +32,8 @@ def self.fetch_settlements
       request.get "?expand[]=recipient_settlement"
     end
 
-    def reversals
-      self.class.request.get "#{id}/reversals"
+    def self.reversals(id)
+      request.get "#{id}/reversals"
     end  
   end
 end
diff --git a/test/razorpay/test_transfer.rb b/test/razorpay/test_transfer.rb
@@ -76,15 +76,15 @@ def test_transfer_direct_transfer
 
     def test_fetch_reversals
       stub_get(%r{/transfers/#{@transfer_id}/reversals$}, 'reversals_collection')
-      transfer = Razorpay::Transfer.fetch(@transfer_id).reversals
+      transfer = Razorpay::Transfer.reversals(@transfer_id)
       assert_instance_of Razorpay::Collection, transfer , 'Transfer should be an array'
       refute_empty transfer.items , 'Transfer should be more than one'
     end
 
     def test_fetch_reversals_exception 
       stub_get(%r{/transfers/#{@transfer_id}/reversals$}, 'transfer_error')
         assert_raises(Razorpay::Error) do
-        transfer = Razorpay::Transfer.fetch(@transfer_id).reversals
+        transfer = Razorpay::Transfer.reversals(@transfer_id)
         if transfer.error
             raise Razorpay::Error.new, transfer.error['code']
         end