Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Test coverage and automate publish #213

Merged
merged 22 commits into from
Oct 13, 2023
Merged

Conversation

ankitdas13
Copy link
Contributor

Note :- Please follow the below points while attaching test cases document link below:

- If label Tested is added then test cases document URL is mandatory.

- Link added should be a valid URL and accessible throughout the org.

- If the branch name contains hotfix / revert by default the BVT workflow check will pass.

Test Case Document URL
Please paste test case document link here....

@ankitdas13 ankitdas13 self-assigned this Apr 24, 2023
@ankitdas13 ankitdas13 added the TestingNotRequired TestingNotRequired label for BVT label Apr 24, 2023
@codecov-commenter
Copy link

codecov-commenter commented Apr 25, 2023

Codecov Report

❗ No coverage uploaded for pull request base (master@4133883). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #213   +/-   ##
=========================================
  Coverage          ?   97.86%           
=========================================
  Files             ?       29           
  Lines             ?      515           
  Branches          ?        0           
=========================================
  Hits              ?      504           
  Misses            ?       11           
  Partials          ?        0           

@ankitdas13 ankitdas13 requested a review from ndhaka007 April 27, 2023 11:29
Comment on lines 73 to 77
mkdir -p $HOME/.gem
touch $HOME/.gem/credentials
chmod 0600 $HOME/.gem/credentials
printf -- "---\n:rubygems_api_key: ${GEM_API_KEY}\n" > $HOME/.gem/credentials
gem push gems/*.gem --otp $(oathtool --base32 --totp "$GEM_2FA_SECRET_KEY")

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you explain this or share some resources? What is happening here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, you can check this post
https://andrewm.codes/blog/automating-ruby-gem-releases-with-github-actions/
and line no 77 i have added 2FA auth, although i am not sure 2fa is mandatory or not in razorpay repo rubygems until i added as a collaborator. but if there is no 2FA mandatory, then we will remove --otp $(oathtool --base32 --totp "$GEM_2FA_SECRET_KEY")

created clone of this repo and publish it (for testing). Check this once
https://github.com/ankitdas13/razorruby/actions/runs/4805861071

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

on the shared link it says we are building the image and publishing it. My concern is we have a build step do we need to build again? Can't we directly publish it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if we want to publish it directly then we have to save the build with help of this actions/upload-artifact@v3 in git environment and while publish we can use this save build by using this actions/download-artifact@v3

@ankitdas13 ankitdas13 requested a review from ndhaka007 April 27, 2023 13:10
@ankitdas13 ankitdas13 added Tested and removed TestingNotRequired TestingNotRequired label for BVT labels Oct 13, 2023
Copy link

@ndhaka007 ndhaka007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ankitdas13 ankitdas13 added TestingNotRequired TestingNotRequired label for BVT and removed Tested labels Oct 13, 2023
@ankitdas13 ankitdas13 merged commit a283340 into master Oct 13, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
TestingNotRequired TestingNotRequired label for BVT
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants