Runs only one amp in an AIO #53
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To reduce memory consumption + CPU run only one amp (SINGLE) instead of two (ACTIVE_PASSIVE) when running in an AIO.
mattt416
approved these changes
Jun 14, 2018
|
The snapshot test passed (see this), but tbh the run didn't seem to take a whole lot longer than one running two amphora instances. I'd probably let this PR sit until we see frequent failures because of the instance swapping. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To reduce memory consumption + CPU run only one
amp (SINGLE) instead of two (ACTIVE_PASSIVE) when
running in an AIO.