-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add PtestSuite to run on PRs #554
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: anchit-chandran <[email protected]>
anchit-chandran
had a problem deploying
to
development
August 29, 2023 10:05
— with
GitHub Actions
Failure
…nyway for setting up test db) Signed-off-by: anchit-chandran <[email protected]>
…ng inside github workflow Signed-off-by: anchit-chandran <[email protected]>
anchit-chandran
had a problem deploying
to
development
August 29, 2023 10:18
— with
GitHub Actions
Failure
Signed-off-by: anchit-chandran <[email protected]>
anchit-chandran
had a problem deploying
to
development
August 29, 2023 10:37
— with
GitHub Actions
Failure
Tests currently failing because:
|
Signed-off-by: anchit-chandran <[email protected]>
Signed-off-by: anchit-chandran <[email protected]>
anchit-chandran
had a problem deploying
to
development
September 1, 2023 09:47
— with
GitHub Actions
Failure
Signed-off-by: anchit-chandran <[email protected]>
Signed-off-by: anchit-chandran <[email protected]>
anchit-chandran
temporarily deployed
to
development
September 1, 2023 09:57
— with
GitHub Actions
Inactive
eatyourpeas
approved these changes
Sep 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar workflow to autodeploys, but runs on PR instead of after merge.
This helps promote safe, high-quality software dev practices + minimise human errors. Bypassing the pytests / reviewer checks CAN be done in a "break glass for emergency" situation, but will need to be a conscious decision, against Incubator 'norms'
Also changes git hash solution to combo of mine and @pacharanero :
NOTE: updated the git hash to also be visible to rcpch staff / audit members. found it would be helpful in cases where they report a bug that should be fixed, but unsure what version they're looking at.