Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PtestSuite to run on PRs #554

Merged
merged 8 commits into from
Sep 4, 2023
Merged

Add PtestSuite to run on PRs #554

merged 8 commits into from
Sep 4, 2023

Conversation

anchit-chandran
Copy link
Collaborator

@anchit-chandran anchit-chandran commented Aug 29, 2023

Similar workflow to autodeploys, but runs on PR instead of after merge.

This helps promote safe, high-quality software dev practices + minimise human errors. Bypassing the pytests / reviewer checks CAN be done in a "break glass for emergency" situation, but will need to be a conscious decision, against Incubator 'norms'

Also changes git hash solution to combo of mine and @pacharanero :

  • In local development, will look inside .git folder
  • In environments where no .git folder exists, e.g. the GitHubActions environments for build + deploys, those workflows add a git hash .txt file, from which the git info can be read

NOTE: updated the git hash to also be visible to rcpch staff / audit members. found it would be helpful in cases where they report a bug that should be fixed, but unsure what version they're looking at.

Signed-off-by: anchit-chandran <[email protected]>
…nyway for setting up test db)

Signed-off-by: anchit-chandran <[email protected]>
…ng inside github workflow

Signed-off-by: anchit-chandran <[email protected]>
@anchit-chandran
Copy link
Collaborator Author

Tests currently failing because:

  1. Census platform returning None -> is the secrets env var updated?
  2. Git branch context processor can't find the .git/ref file @pacharanero unsure how your new solution for that works - might need your help coming up with error handling for running this inside GHActions tests

@anchit-chandran anchit-chandran temporarily deployed to development September 1, 2023 09:57 — with GitHub Actions Inactive
@eatyourpeas eatyourpeas merged commit 3f0b369 into development Sep 4, 2023
1 check passed
@eatyourpeas eatyourpeas deleted the add-pytest-for-prs branch September 4, 2023 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants