Eatyourpeas/issue538

[eatyourpeas]

Overview

This fixes 4 things to do with the workflow for transferring children between centres.

1. remove E12 users from the email cc when the transfer request is sent
2. if the transfer is refused and the child is returned to the original trust, fix the bug that the original sending organisation is added to list of historical trusts.
3. change the reject/accept modal to read 'I confirm' rather than the more ambiguous 'I accept'
4. Remove the current organisation from the dropdown which appears when the transfer button is pressed. This prevents the user from transferring a child into the organisation where they already are.

Code changes

Changes are made in 3 files
case_views.py - this deletes the new site object created if the transfer is rejected, and reanimates the previous record.

registration_views: removes members of the RCPCH audit team from the cc in tranfer requests email. removes current organisation from transfer organisation list

case_table: change the wording in the modal button

Documentation changes (done or required as a result of this PR)

Bug fix, so no implications for documentation

Related Issues

#538

Mentions

@mentions of the person or team responsible for reviewing proposed changes.
@anchit_chandran @pacharanero

[eatyourpeas]

Forgive me for piggybacking these changes on the back of this PR. It is related and equally urgent, so thought it might acceptable to couple the two issues.

In addition to the items/fixes listed in the PR above, subsequent commits have:

1. removed a filter bug where local health boards did not see their organisations' users
2. removed the empty brackets in the footer segment in case form

These items are in templates/epilepsy12/forms/case.html and views/user_management_views.py

The main fix is a bigger issue though:

The problem

Currently if a child is transferred between centres, if the transfer is rejected (or sometimes accepted), the relationships it has with other centres in the Assessment tab which track general paediatric, neurology and surgical care are lost.

Background

The Site model, as the middle table in the M2M relationship between Case and Organisation, stores information about the relationship a child has with an organisation. For each organisation involved in a child's care, either current or historic, a record is stored in the Site model. Flags document if a Site is actively involved in care, and the nature of the relationship (lead site, general paediatric/neuro or surgical site). To build a chronology of sites that have historically led the care of a child's epilepsy, it is possible to have multiple records for different organisations where lead site status is true, but active involvement status is false. These appear in the registration form as historical lead sites if they exist.

By contrast, any other relationships the site may have (not lead status, but provide general paediatric, neurology or epilepsy surgery care) are stored only once - no chronology for these exist. If a child moves its surgical care, a new record is created reflecting the change and the old one deleted.

It becomes more complicated if:

1. A lead centre transfers lead centre status to another organisation which is already involved in the care of the child
2. A lead centre transfers lead centre status to another organisation but continues to offer general paediatric, neurology or surgical care
3. Any requests for transfer are then rejected - as everything needs to be put back the way it was before the request was made

Having spent some time looking at these edge cases I am fairly sure this now works the way it was intended but really we need some tests. I have not had time so far to add these, and in the interests of urgency, am submitting this fix , with a view to adding some tests later on. I am really happy to help with the review of this PR as it is larger and more complicated than I would like.

[pacharanero]

Reviewed with @dc2007git and @eatyourpeas - tested the changes to lead site transfer logic with success.
Closes #538