Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

translation of choosing-the-state-structure page in Hindi #221

Merged

Conversation

BrijenMakwana
Copy link

@BrijenMakwana BrijenMakwana commented Mar 3, 2023

Translation of choosing-the-state-structure page in Hindi

Review Progress:

  • Overview
  • Principles for structuring state
  • Group related state
  • Avoid contradictions in state
  • Avoid redundant state
  • Avoid duplication in state
  • Avoid deeply nested state
  • Recap
  • Challenges

Copy link
Member

@arshadkazmi42 arshadkazmi42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for taking this up.

I have added review till line 102.

Lets get these fixed and post that we can continue with the review.
To know more about our review guides lines refer #23

beta/src/pages/learn/choosing-the-state-structure.md Outdated Show resolved Hide resolved
beta/src/pages/learn/choosing-the-state-structure.md Outdated Show resolved Hide resolved
beta/src/pages/learn/choosing-the-state-structure.md Outdated Show resolved Hide resolved
beta/src/pages/learn/choosing-the-state-structure.md Outdated Show resolved Hide resolved
beta/src/pages/learn/choosing-the-state-structure.md Outdated Show resolved Hide resolved
beta/src/pages/learn/choosing-the-state-structure.md Outdated Show resolved Hide resolved
beta/src/pages/learn/choosing-the-state-structure.md Outdated Show resolved Hide resolved
beta/src/pages/learn/choosing-the-state-structure.md Outdated Show resolved Hide resolved
beta/src/pages/learn/choosing-the-state-structure.md Outdated Show resolved Hide resolved
@BrijenMakwana
Copy link
Author

Thank you for taking this up.

I have added review till line 102.

Lets get these fixed and post that we can continue with the review. To know more about our review guides lines refer #23

I have made the changes that you have asked 👍🏻

Copy link
Member

@arshadkazmi42 arshadkazmi42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for working on the fixes.

I have added some more reviews till line 375.

Let's get these fixed and post that we can continue further with the review.

beta/src/pages/learn/choosing-the-state-structure.md Outdated Show resolved Hide resolved
beta/src/pages/learn/choosing-the-state-structure.md Outdated Show resolved Hide resolved
beta/src/pages/learn/choosing-the-state-structure.md Outdated Show resolved Hide resolved
beta/src/pages/learn/choosing-the-state-structure.md Outdated Show resolved Hide resolved
beta/src/pages/learn/choosing-the-state-structure.md Outdated Show resolved Hide resolved
beta/src/pages/learn/choosing-the-state-structure.md Outdated Show resolved Hide resolved
beta/src/pages/learn/choosing-the-state-structure.md Outdated Show resolved Hide resolved
beta/src/pages/learn/choosing-the-state-structure.md Outdated Show resolved Hide resolved
beta/src/pages/learn/choosing-the-state-structure.md Outdated Show resolved Hide resolved
@BrijenMakwana
Copy link
Author

Thank you for working on the fixes.

I have added some more reviews till line 375.

Let's get these fixed and post that we can continue further with the review.

I have made the changes 👍🏻

@BrijenMakwana
Copy link
Author

Thank you for working on the fixes.

I have added some more reviews till line 375.

Let's get these fixed and post that we can continue further with the review.

@arshadkazmi42 Changes have been made, it's a request to provide a review 👍

Copy link
Member

@arshadkazmi42 arshadkazmi42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added more reviews till line 818.

Lets get these fixed and then we can continue further.

beta/src/pages/learn/choosing-the-state-structure.md Outdated Show resolved Hide resolved
beta/src/pages/learn/choosing-the-state-structure.md Outdated Show resolved Hide resolved
beta/src/pages/learn/choosing-the-state-structure.md Outdated Show resolved Hide resolved
beta/src/pages/learn/choosing-the-state-structure.md Outdated Show resolved Hide resolved
beta/src/pages/learn/choosing-the-state-structure.md Outdated Show resolved Hide resolved
beta/src/pages/learn/choosing-the-state-structure.md Outdated Show resolved Hide resolved
beta/src/pages/learn/choosing-the-state-structure.md Outdated Show resolved Hide resolved
@BrijenMakwana
Copy link
Author

@arshadkazmi42 I have made the changes.

@BrijenMakwana
Copy link
Author

@arshadkazmi42 My pull request is open for almost 3 months now. It's a request to provide a review soon so it can be merged.

@arshadkazmi42
Copy link
Member

@BrijenMakwana Thank you for the reminder and your patience. I am a bit busy and will be going through it soon.

Copy link
Member

@arshadkazmi42 arshadkazmi42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for working on the fixes.

I have added review to rest of the file, once these are fixed we can get this merged

beta/src/pages/learn/choosing-the-state-structure.md Outdated Show resolved Hide resolved
beta/src/pages/learn/choosing-the-state-structure.md Outdated Show resolved Hide resolved
beta/src/pages/learn/choosing-the-state-structure.md Outdated Show resolved Hide resolved
beta/src/pages/learn/choosing-the-state-structure.md Outdated Show resolved Hide resolved
beta/src/pages/learn/choosing-the-state-structure.md Outdated Show resolved Hide resolved
beta/src/pages/learn/choosing-the-state-structure.md Outdated Show resolved Hide resolved
beta/src/pages/learn/choosing-the-state-structure.md Outdated Show resolved Hide resolved
beta/src/pages/learn/choosing-the-state-structure.md Outdated Show resolved Hide resolved
beta/src/pages/learn/choosing-the-state-structure.md Outdated Show resolved Hide resolved
beta/src/pages/learn/choosing-the-state-structure.md Outdated Show resolved Hide resolved
@BrijenMakwana
Copy link
Author

@arshadkazmi42 I have made all the changes. You can merge it. 😀

@arshadkazmi42
Copy link
Member

Thank you @BrijenMakwana for working on this. There seems to be a conflict. Can you fix those conflicts? post that we can get this merged.

@arshadkazmi42
Copy link
Member

@BrijenMakwana I see a lot of changes which are not related to this PR in the last commit. Can you revert the last commit and resolve the conflicts only from this file src/content/learn/choosing-the-state-structure.md

Let me know if you need any help with it.

@BrijenMakwana
Copy link
Author

@BrijenMakwana I see a lot of changes which are not related to this PR in the last commit. Can you revert the last commit and resolve the conflicts only from this file src/content/learn/choosing-the-state-structure.md

Let me know if you need any help with it.

Sure. I'm working on it. Will let you know

@BrijenMakwana BrijenMakwana force-pushed the choosingTheStateStructureBrijen branch from aa85fe4 to 018e647 Compare May 28, 2023 09:45
@BrijenMakwana
Copy link
Author

BrijenMakwana commented May 28, 2023

@arshadkazmi42 Please check if it can be merged now.

@github-actions
Copy link

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@arshadkazmi42 arshadkazmi42 merged commit d4f887f into reactjs:main May 28, 2023
@arshadkazmi42
Copy link
Member

Thank you @BrijenMakwana for working on this and thank you for your patience working on all the fixes.

@BrijenMakwana
Copy link
Author

Thank you @BrijenMakwana for working on this and thank you for your patience working on all the fixes.

Thank you very much. I enjoyed working on it 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1st Review First phase of review beta
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants