-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
translation of choosing-the-state-structure page in Hindi #221
translation of choosing-the-state-structure page in Hindi #221
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for taking this up.
I have added review till line 102.
Lets get these fixed and post that we can continue with the review.
To know more about our review guides lines refer #23
I have made the changes that you have asked 👍🏻 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for working on the fixes.
I have added some more reviews till line 375.
Let's get these fixed and post that we can continue further with the review.
I have made the changes 👍🏻 |
@arshadkazmi42 Changes have been made, it's a request to provide a review 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added more reviews till line 818.
Lets get these fixed and then we can continue further.
@arshadkazmi42 I have made the changes. |
@arshadkazmi42 My pull request is open for almost 3 months now. It's a request to provide a review soon so it can be merged. |
@BrijenMakwana Thank you for the reminder and your patience. I am a bit busy and will be going through it soon. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for working on the fixes.
I have added review to rest of the file, once these are fixed we can get this merged
@arshadkazmi42 I have made all the changes. You can merge it. 😀 |
Thank you @BrijenMakwana for working on this. There seems to be a conflict. Can you fix those conflicts? post that we can get this merged. |
@BrijenMakwana I see a lot of changes which are not related to this PR in the last commit. Can you revert the last commit and resolve the conflicts only from this file Let me know if you need any help with it. |
Sure. I'm working on it. Will let you know |
aa85fe4
to
018e647
Compare
45bb7d3
to
3fb8188
Compare
|
Size changes📦 Next.js Bundle Analysis for react-devThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
Thank you @BrijenMakwana for working on this and thank you for your patience working on all the fixes. |
Thank you very much. I enjoyed working on it 🙂 |
Translation of choosing-the-state-structure page in Hindi
Review Progress: