only inline if dominating force has a framestate

reactorlabs · May 17, 2022 · 138ff14 · 138ff14
1 parent cd486a6
commit 138ff14
Showing 1 changed file with 8 additions and 1 deletion.
diff --git a/rir/src/compiler/opt/force_dominance.cpp b/rir/src/compiler/opt/force_dominance.cpp
@@ -192,7 +192,14 @@ bool ForceDominance::apply(Compiler&, ClosureVersion* cls, Code* code,
                         Value* eager = mkarg->eagerArg();
                         f->replaceUsesWith(eager);
                         next = bb->remove(ip);
-                    } else if (toInline.count(f)) {
+                    } else if (toInline.count(f) &&
+                               // Can't inline a promise with Assumes if the
+                               // dominating Force doesn't have a Framestate
+                               (f->frameState() ||
+                                Visitor::check(mkarg->prom()->entry,
+                                               [](Instruction* i) {
+                                                   return !Assume::Cast(i);
+                                               }))) {
                         anyChange = true;
                         Promise* prom = mkarg->prom();
                         BB* split =