Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove broken check. #150

Merged
merged 1 commit into from
Jun 6, 2017
Merged

Remove broken check. #150

merged 1 commit into from
Jun 6, 2017

Conversation

mhyee
Copy link
Member

@mhyee mhyee commented Jun 6, 2017

This check is performed a few lines below. Worse, the check is missing
begin/end, so nothing actually happens to the input programs.

This check is performed a few lines below. Worse, the check is missing
begin/end, so nothing actually happens to the input programs.
@mhyee mhyee merged commit 880e686 into reactorlabs:master Jun 6, 2017
@mhyee mhyee deleted the remove-broken-check branch June 6, 2017 03:12
@o-
Copy link
Contributor

o- commented Jun 6, 2017

ehm, this was there intentionally (unfinished though)...

There is a chicken-egg problem.

  1. autofix breaks on broken programs
  2. check complains about broken scope

so the idea was to run check first but only report errors that autofix would crash on, then autofix, then re-run checks and report all errors.

@mhyee
Copy link
Member Author

mhyee commented Jun 6, 2017

Opened a new issue for tracking: #152.

I had to remove it because it was blocking me. I was very confused when I ran sourir and nothing happened.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants