Skip to content

Commit

Permalink
upgrade helm from v2 -> v3
Browse files Browse the repository at this point in the history
The go.mod replacements are copied over from the replacements done by
helm (using v3 tag), which means I didn't initiate them. We might want
to watch for changes in this area.

Changes I did to the source:

 1. renamed chart.GetDependencies() -> chart.Dependencies()
 2. replaced chartutil.Load with loader.Load
 3. replaced usage of `chart.Dependencies` property with
 chart.SetDependencies
 4. adopted the changes made to chart.Values (previously was a helm
 `File`), now it's simply map[string]interface{}.
 5. adopted the removal of chart.Template and changed everything to
 chart.File
 6. copied over the `transform` function as it's no longer part of the
 public API. I think this is fine, as it's a only a string replacement
 anyway.

I did all these changes without spending to much attention to the new
API. I do feel that it's much more clean and organized though. Should
make things easier in the future. cheers.
  • Loading branch information
jostillmanns committed Nov 17, 2019
1 parent c3b70cf commit acc7a9a
Show file tree
Hide file tree
Showing 5 changed files with 542 additions and 53 deletions.
40 changes: 25 additions & 15 deletions go.mod
Original file line number Diff line number Diff line change
@@ -1,19 +1,29 @@
module realcloud.tech/pligos

require (
github.com/BurntSushi/toml v0.3.1 // indirect
github.com/Masterminds/semver v1.4.2 // indirect
github.com/davecgh/go-spew v1.1.1 // indirect
github.com/ghodss/yaml v1.0.0 // indirect
github.com/gobwas/glob v0.2.3 // indirect
github.com/golang/protobuf v1.2.0
github.com/inconshreveable/mousetrap v1.0.0 // indirect
github.com/pmezard/go-difflib v1.0.0 // indirect
github.com/spf13/cobra v0.0.3
github.com/spf13/pflag v1.0.3 // indirect
github.com/stretchr/testify v1.2.2
golang.org/x/sync v0.0.0-20190423024810-112230192c58 // indirect
gopkg.in/yaml.v2 v2.2.2
k8s.io/apimachinery v0.0.0-20181227073029-9c4c36654334 // indirect
k8s.io/helm v2.12.1+incompatible
github.com/spf13/cobra v0.0.5
github.com/stretchr/testify v1.4.0
gopkg.in/yaml.v2 v2.2.4
helm.sh/helm/v3 v3.0.0
)

go 1.13

replace (
// github.com/Azure/go-autorest/autorest has different versions for the Go
// modules than it does for releases on the repository. Note the correct
// version when updating.
github.com/Azure/go-autorest/autorest => github.com/Azure/go-autorest/autorest v0.9.0
github.com/docker/docker => github.com/moby/moby v0.7.3-0.20190826074503-38ab9da00309

// Kubernetes imports github.com/miekg/dns at a newer version but it is used
// by a package Helm does not need. Go modules resolves all packages rather
// than just those in use (like Glide and dep do). This sets the version
// to the one oras needs. If oras is updated the version should be updated
// as well.
github.com/miekg/dns => github.com/miekg/dns v0.0.0-20181005163659-0d29b283ac0f
gopkg.in/inf.v0 v0.9.1 => github.com/go-inf/inf v0.9.1
gopkg.in/square/go-jose.v2 v2.3.0 => github.com/square/go-jose v2.3.0+incompatible

rsc.io/letsencrypt => github.com/dmcgowan/letsencrypt v0.0.0-20160928181947-1847a81d2087
)
Loading

0 comments on commit acc7a9a

Please sign in to comment.