Update .vscode cmake.sourceDirectory #1521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 7846748656
💛 - Coveralls |
|
The title seems to imply that the CMakePreset file will be moved, but the PR doesn't actually do that. |
nielsenko
reviewed
Feb 26, 2024
| @@ -29,6 +29,7 @@ linter: | |||
| rules: | |||
| avoid_relative_lib_imports: false | |||
| package_api_docs: true | |||
| dangling_library_doc_comments: false | |||
There was a problem hiding this comment.
I prefer that we don't disable recommended lints, but let us keep it for now, and fix the code later.
nielsenko
approved these changes
Feb 26, 2024
nirinchev
changed the title
|
Yeah, originally, I thought I need to move the presets to have them vscode pick them up, but then discovered the |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.