RDART-992: Const initializer evaluation is too simple #1607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nielsenko
changed the title
Pull Request Test Coverage Report for Build 8471153652Details
💛 - Coveralls |
nirinchev
approved these changes
Mar 27, 2024
Comment on lines
395
to
398
| if (initExpression is Literal) return true; | ||
| if (initExpression is InstanceCreationExpression) return initExpression.isConst; | ||
| if (initExpression is PrefixExpression) return _isValidFieldInitializer(initExpression.operand); | ||
| return false; |
There was a problem hiding this comment.
Can we rewrite this with a switch expression? I'm not a huge fan of series of 1-line ifs.
elle-j
approved these changes
Mar 27, 2024
packages/realm_generator/test/good_test_data/const_initializer.dart
Outdated
Show resolved
Hide resolved
papafe
added a commit
that referenced
this pull request
Apr 8, 2024
* main: RDART-996: Don't serialize backlinks (#1617) Update README.md (#1608) RDART-983: Refactor how we open dynamic library to give better error message (#1614) RDART-991: Rename Key enum (#1613) RDART-992: Handle Identifer expression as well (#1612) Add workflow_dispatch for development Common setup script (#1610) RDART-992: Const initializer evaluation is too simple (#1607) # Conflicts: # CHANGELOG.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1606