-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RDART-983: Refactor how we open dynamic library to give better error message #1614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nielsenko
changed the title
Refactor how we open dynamic library to give better error message
RDART-983: Refactor how we open dynamic library to give better error message
Apr 2, 2024
Pull Request Test Coverage Report for Build 8536025352Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
elle-j
approved these changes
Apr 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice with improved error messages 🙂 Just have some small suggestions.
nielsenko
force-pushed
the
kn/refactor-dlopen
branch
from
April 3, 2024 08:52
094d3f3
to
cc72df9
Compare
papafe
added a commit
that referenced
this pull request
Apr 8, 2024
* main: RDART-996: Don't serialize backlinks (#1617) Update README.md (#1608) RDART-983: Refactor how we open dynamic library to give better error message (#1614) RDART-991: Rename Key enum (#1613) RDART-992: Handle Identifer expression as well (#1612) Add workflow_dispatch for development Common setup script (#1610) RDART-992: Const initializer evaluation is too simple (#1607) # Conflicts: # CHANGELOG.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to give a better error message, if we fail to load the native shared library.
In the process It changes how we attempt to open it.
First of all it only tries one place when running under the flutter vm, which is the most common scenario. This is not only more correct, but it also improves the error message on failure by not referring to unrelated paths.
Secondly, it will report a hint to add
realm
package if it fails. It is an easy mistake to only addrealm_dart
. We have seen one example already in #1595.Fix: #1595
Sample error messages
Dart script:
Dart pre-compiled exe:
Flutter app: