Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RDART-1007: Compare 8 bytes at a time for Uint8Lists #1628

Merged
merged 4 commits into from
Apr 17, 2024

Conversation

nielsenko
Copy link
Contributor

@nielsenko nielsenko commented Apr 15, 2024

Minor optimization

base of #1632
Fixes: #1634

Copy link

coveralls-official bot commented Apr 15, 2024

Pull Request Test Coverage Report for Build 8718157984

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 86.346%

Totals Coverage Status
Change from base Build 8717604129: 0.0%
Covered Lines: 5856
Relevant Lines: 6782

💛 - Coveralls

@nielsenko nielsenko force-pushed the kn/optimize-realmvalue-eq branch from a721987 to 06defa6 Compare April 16, 2024 13:32
@nielsenko nielsenko marked this pull request as ready for review April 16, 2024 13:34
@nielsenko nielsenko requested a review from nirinchev April 16, 2024 13:34
@nielsenko nielsenko changed the title Compare 8 bytes at a time for Uint8Lists RDART-1007: Compare 8 bytes at a time for Uint8Lists Apr 16, 2024
@nielsenko nielsenko force-pushed the kn/optimize-realmvalue-eq branch from c9a5025 to eca2448 Compare April 16, 2024 17:17
@nielsenko nielsenko requested a review from papafe April 17, 2024 05:49
@nielsenko nielsenko force-pushed the kn/optimize-realmvalue-eq branch from eca2448 to 00858f5 Compare April 17, 2024 07:43
@nielsenko nielsenko merged commit 5e05589 into main Apr 17, 2024
55 of 56 checks passed
@nielsenko nielsenko deleted the kn/optimize-realmvalue-eq branch April 17, 2024 08:26
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Binary comparison is slow (done byte-by-byte)
2 participants