Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RDART-1081: Expose sync timeout options #1764

Merged
merged 4 commits into from
Aug 2, 2024
Merged

RDART-1081: Expose sync timeout options #1764

merged 4 commits into from
Aug 2, 2024

Conversation

nirinchev
Copy link
Member

Fixes #1763

@cla-bot cla-bot bot added the cla: yes label Jul 30, 2024
@nirinchev nirinchev changed the title Expose sync timeout options RDART-1081: Expose sync timeout options Jul 30, 2024
@nirinchev nirinchev force-pushed the ni/sync-timeout-options branch from 5d7bd59 to a7ee137 Compare July 30, 2024 10:22
@coveralls-official Coveralls Official
Copy link

coveralls-official bot commented Jul 30, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 10161117758

Details

  • 8 of 8 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.3%) to 87.18%
Totals Coverage Status
Change from base Build 10138989483: 0.3%
Covered Lines: 6032
Relevant Lines: 6919
💛 - Coveralls

nielsenko
nielsenko approved these changes Jul 30, 2024
View reviewed changes
Copy link
Contributor

@nielsenko nielsenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor nitpicks regarding trailing , for better formatting.

packages/realm_dart/lib/src/configuration.dart Outdated Show resolved Hide resolved
packages/realm_dart/lib/src/app.dart Outdated Show resolved Hide resolved
packages/realm_dart/lib/src/app.dart Outdated Show resolved Hide resolved
@nirinchev nirinchev merged commit 98e77a5 into main Aug 2, 2024
3 checks passed
@nirinchev nirinchev deleted the ni/sync-timeout-options branch August 2, 2024 08:26
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nielsenko nielsenko nielsenko approved these changes

Assignees

@nirinchev nirinchev

Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Expose sync client timeout options
2 participants
@nirinchev @nielsenko