Copy EmbeddedObject on initializing an unmanaged object

[pavel-ship-it]

When creating an unmanaged copy of a managed object with the embedded object property we should make a copy of this embedded object instead of reusing it.

This is fix #6921

[dianaafanador3]

Just a minor comments

[dianaafanador3]

LGTM, only comment It looks like SwiftLint CI Job is failing, because of format issues.

[tgoyne]

We only want to copy the object if it's managed.

[tgoyne]

Suggested change

	if (([obj isKindOfClass:cls] && ![(id)cls isEmbedded]) ||
	([(id)cls isEmbedded] && [obj respondsToSelector:@selector(realm)] && ![obj realm])) {
	if ([obj isKindOfClass:cls] && (![(id)cls isEmbedded] || ![obj realm])) {

I think what you have would call isEmbedded on classes that don't implement it and would accept objects of any type as long as they're an unmanaged embedded object. This also points at some missing tests for initializing an unmanaged object with a value that has an object of a different type in an embedded object field (which copies that object into an unmanaged object of the correct type if all of the required fields are present and have the correct values, and throws an exception if it can't).

[afsmarques]

so, no more updates on this? 😕

[dianaafanador3]

@tgoyne checking this, I think the changes regarding the comments were made, looking at the original issue I think some test are missing what the original intention was, something like the follow.

func testCopyEmbeddedObjectFromManagedObjectInSameRealm() {
        let realm = try! Realm()
        try! realm.write {
            let parent = realm.create(EmbeddedPrimaryParentObject.self, value: [
                "object": ["value": 1],
                "array": [[2]]
            ])

            // Copy Managed object
            let copyA = EmbeddedPrimaryParentObject(value: parent)
            realm.add(copyA, update: .modified)
            XCTAssertEqual(realm.objects(EmbeddedPrimaryParentObject.self).count, 1)

            XCTAssertEqual(parent, copyA)
            XCTAssertEqual(copyA.object!.value, 1)
            XCTAssertEqual(copyA.array.count, 1)

            // Explicit copy of object
            let copyB = EmbeddedPrimaryParentObject()
            copyB.object = EmbeddedTreeObject1(value: parent.object!)
            copyB.array.append(EmbeddedTreeObject1(value: parent.array[0]))
            realm.add(copyB, update: .modified)
            XCTAssertEqual(realm.objects(EmbeddedPrimaryParentObject.self).count, 1)

            XCTAssertEqual(parent, copyB)
            XCTAssertEqual(copyB.object!.value, 1)
            XCTAssertEqual(copyB.array.count, 1)

            // Assign of EmbeddedObject
            let copyC = EmbeddedParentObject()
            copyC.object = parent.object
            assertThrows(realm.add(copyC), "Cannot set a link to an existing managed embedded object")

            let parentUnmanaged = EmbeddedPrimaryParentObject(value: [
                "object": ["value": 4],
                "array": [[5]]
            ])

            // Do not copy unmanaged object
            let copyD = EmbeddedPrimaryParentObject(value: parentUnmanaged)
            XCTAssertTrue(copyD.object === parentUnmanaged.object)
            assertThrows(realm.add(parentUnmanaged), "Cannot set a link to an existing managed embedded object")
        }
    }

Let me know if there are more changes needed on this, or If I should change the current text with the text above.