Fix Time.to_sec_string example #36
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
code/guided-tour/main.topscript
Outdated
| @@ -147,7 +147,7 @@ let log_entry maybe_time message = | |||
| | Some x -> x | |||
| | None -> Time.now () | |||
| in | |||
| Time.to_sec_string time ^ " -- " ^ message | |||
| Time.to_sec_string Time.Zone.local time ^ " -- " ^ message | |||
There was a problem hiding this comment.
The right sequence should be Time.to_sec_string time Time.Zone.local
|
@zzhjerry Thanks for pointing that out! I've replaced the patch. |
|
As of Core version 112.17.00 Time.to_sec_string requires a time zone.
`Time.Zone.local` has been removed from the package `core`. The current version, 0.16.1, has a deprecation warning in its place. There is a platform-specific replacement in `core-unix`. To avoid requiring `core-unix`, let's change the time zone to UTC.
|
Core has undergone changes since I submitted the PR. I have updated the PR for version 0.16.1 (the version numbering scheme has changed, too). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of Core version 112.17.00 Time.to_sec_string requires a time zone.