-
Notifications
You must be signed in to change notification settings - Fork 46
dev meeting 20200909
Present at the meeting:
- Guillaume Petiot (@gpetiot)
- Nathan Rebours (@NathanReb)
- Nathan reviews opened PRs so we can merge them
- Guillaume looks into the state of OMD to see how usable it would be for MDX
- Sonja works on #269
- Sonja adds a MDX tutorial to the README
Nathan had very little time to work on MDX these past few weeks but he did setup a working changelog check! He also spent some time reviewing Guillaume's PRs but most of them haven't been merged yet so that will be his main focus on MDX. He also worked a bit on improving the MDX stanza in dune but there's no PR opened for this yet.
Guillaume worked on the opened PRs to improve them and also looked into two new issues. First one being an improvement to the file includes block where you don't have to add an empty block for it to work the first time. This is a nice feature but we have to remember that the header is the user's responsibility so we should carefully set it. We agreed that setting it to ocaml
for .ml(i)
files is okay but for the rest we'll leave it empty and let the user pick.
Another important feature he worked on is a mode allowing users to suppress unwanted feedback in toplevel blocks such as repeated type definitions. This is definitely a good feature but we're not a 100% clear what should be suppressed and how configurable it should be. I think we should aim at finding a suppression level acceptable for most. We'll start by flagging this feature as experimental and wait for feedback from @yminsky who requested it initially to converge towards the best suited solution.
We also discussed the old Jupyter PR. Adding a Markdown -> Jupyter notebook converter definitely feels like a good feature but we'd like it to be better defined before merging it and having to maintain. We'll schedule a call with the parties involved to define the scope of the feature and whether MDX is the right place for this feature or not. We're willing to integrate it but we don't want to rush things on this.