Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: parse and print attributes in let binding ops #2777

Merged
merged 2 commits into from
Jul 29, 2024

Conversation

anmonteiro
Copy link
Member

fixes #2649

@anmonteiro anmonteiro merged commit ae76070 into master Jul 29, 2024
15 checks passed
@anmonteiro anmonteiro deleted the anmonteiro/binding-op-attributes branch July 29, 2024 01:12
anmonteiro added a commit to anmonteiro/opam-repository that referenced this pull request Oct 21, 2024
CHANGES:

- Support `module%ppx` syntax (@anmonteiro,
  [reasonml/reason#2771](reasonml/reason#2771))
- Extend open to arbitrary module expression (@anmonteiro,
  [reasonml/reason#2773](reasonml/reason#2773))
- Wrap `let lazy patterns = ..` in parentheses (`let lazy(patterns) = ..`)
  (@anmonteiro, [reasonml/reason#2774](reasonml/reason#2774))
- Print poly variants as normal variansts (@sander Spies,
  [reasonml/reason#2708](reasonml/reason#2708))
- Improve printing of anonymous function return type (@sander Spies,
  [reasonml/reason#2686](reasonml/reason#2686))
- Improve printing of destructuring with local open (@sander Spies,
  [reasonml/reason#2684](reasonml/reason#2684)).
- Parse and print attributes in binding `let` ops (@anmonteiro,
  [reasonml/reason#2777](reasonml/reason#2777)).
- Parse polymorphic variants starting with `[|` (@anmonteiro,
  [reasonml/reason#2781](reasonml/reason#2781))
- Always add a line break in records with 2 or more fields (@anmonteiro,
  [reasonml/reason#2779](reasonml/reason#2779))
- Always break nonempty doc comments after `*/` (@anmonteiro,
  [reasonml/reason#2780](reasonml/reason#2780))
- Improve printing of arrows with labelled arguments (@anmonteiro,
  [reasonml/reason#2778](reasonml/reason#2778))
- Parse and print extensions in `open%foo` expressions and structure items
  (@anmonteiro, [reasonml/reason#2784](reasonml/reason#2784))
- Add support for module type substitutions
  (@anmonteiro, [reasonml/reason#2785](reasonml/reason#2785))
- Support `type%foo` extension sugar syntax (@anmonteiro,
  [reasonml/reason#2790](reasonml/reason#2790))
- Support quoted extensions (@anmonteiro,
  [reasonml/reason#2794](reasonml/reason#2794))
- Parse universal type variables in signature items (@anmonteiro,
  [reasonml/reason#2797](reasonml/reason#2797))
- Fix formatting of callbacks with sequence expressions (@anmonteiro,
  [reasonml/reason#2799](reasonml/reason#2799))
- Fix printing of attributes on module expressions (@anmonteiro,
  [reasonml/reason#2803](reasonml/reason#2803))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

refmt breaks with multiline comment and OCaml 4.08 Binding operators
1 participant