Simple paging #8
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 similar comments
3 similar comments
3 similar comments
reclosedev
reviewed
Jun 22, 2017
lathermail/validators.py
Outdated
| @@ -20,3 +20,5 @@ def iso_date(value): | |||
| parser.add_argument("created_at_lt", type=iso_date) | |||
| parser.add_argument("created_at_gt", type=iso_date) | |||
| parser.add_argument("read", type=types.boolean) | |||
| parser.add_argument("X-Mail-Offset", type=int, dest="offset", location="headers", default=0) | |||
There was a problem hiding this comment.
This arguments should be passed as query parameters, not headers.
| @@ -90,6 +95,17 @@ lathermailApp.controller('lathermailCtrl', function ($scope, $http, $routeParams | |||
| }); | |||
| }; | |||
|
|
|||
| $scope.getNextMessagesPage = function(direction) { | |||
| if (direction === 'right') { | |||
There was a problem hiding this comment.
right and left are bad names. Please use forward backwards
| @@ -90,6 +95,17 @@ lathermailApp.controller('lathermailCtrl', function ($scope, $http, $routeParams | |||
| }); | |||
| }; | |||
|
|
|||
| $scope.getNextMessagesPage = function(direction) { | |||
| if (direction === 'right') { | |||
| $scope.messages.length < $scope.offsetStep ? $scope.offset += 0 : $scope.offset += $scope.offsetStep; | |||
… change; change tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now only 10 messages per page will be shown in messages list.
...and only with SQLAlchemy yet.