Skip to content
This repository has been archived by the owner on Sep 8, 2022. It is now read-only.

Update react-universal-component to the latest version 🚀 #77

Merged
merged 2 commits into from
Jul 24, 2018

Conversation

greenkeeper[bot]
Copy link
Contributor

@greenkeeper greenkeeper bot commented Jul 20, 2018

Version 3.0.0 of react-universal-component was just published.

Dependency react-universal-component
Current Version 2.9.0
Type dependency

The version 3.0.0 is not covered by your current version range.

If you don’t accept this pull request, your project will work just like it did before. However, you might be missing out on a bunch of new features, fixes and/or performance improvements from the dependency update.

It might be worth looking into these changes and trying to get this project onto the latest version of react-universal-component.

If you have a solid test suite and good coverage, a passing build is a strong indicator that you can take advantage of these changes directly by merging the proposed change into your project. If the build fails or you don’t have such unconditional trust in your tests, this branch is a great starting point for you to work on the update.


Commits

The new version differs by 13 commits.

  • 58ca92b Merge pull request #127 from faceyspacey/webpack-4
  • d5ad0de fix(src/index.js): Typo in babel plugin checker
  • 46a670f Merge pull request #122 from ScriptedAlchemy/webpack-4
  • 42c2166 test(flowconfig): Added chalk to ignore list
  • bf5f31f docs(README): Refactoring Readme
  • bf3b09d test(src): Fixing flow types for babel chunk detection
  • ada6a72 chore(package.json): Adding keywrods and collaberators
  • 698bd2f feat(src/requireUniversalModule): Handle string based chunknames (dashes)
  • d24230a chore(package.json,yarn.lock): devDependencies updages
  • bf7f1bf Merge pull request #120 from EdonGashi/patch-1
  • 3752c46 Update README.md
  • 6202d2d refactor(src/index.js): Fixed long lines of hoist
  • 3973374 Added preloadWeak static method

See the full diff

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.


Your Greenkeeper bot 🌴

@yosuke-furukawa
Copy link
Member

むむ、 npm ci と package.json に変更があるから greenkeeper 失敗するっぽいな。
これなんかわかります? @kt3k

@yosuke-furukawa
Copy link
Member

greenkeeperio/greenkeeper-lockfile#156 (comment) これか。。

install: case $TRAVIS_BRANCH in greenkeeper*) npm i;; *) npm ci;; esac;

こうやって書かないといけないんだな。

@yosuke-furukawa
Copy link
Member

travis はこれでいいとしても、 circle ci はどうなんだろう。

@yosuke-furukawa
Copy link
Member

$CIRCLE_BRANCH か。

@yosuke-furukawa yosuke-furukawa merged commit 24daf4d into master Jul 24, 2018
@kt3k kt3k deleted the greenkeeper/react-universal-component-3.0.0 branch July 25, 2018 00:28
@kt3k
Copy link
Collaborator

kt3k commented Jul 25, 2018

なるほど、npm ci って lock ファイルと整合性が無いと fail なんですね、知りませんでしたー

@yosuke-furukawa
Copy link
Member

npm ci は package-lock から作るだけなんでyarnと一緒ですね。やってることは。

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants