Skip to content

Commit

Permalink
chores on upgrade test suite (#2110)
Browse files Browse the repository at this point in the history
chores on the upgrade testing test suites:

- fixing RoboCop issues and/or adding comments to ignore when needed
- formatting according to robotidy
  • Loading branch information
asanzgom authored Dec 3, 2024
2 parents 0e5a93e + f286be7 commit cc96d97
Show file tree
Hide file tree
Showing 5 changed files with 538 additions and 391 deletions.
4 changes: 2 additions & 2 deletions ods_ci/tests/Resources/CLI/MustGather/MustGather.resource
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ Resource ../../Common.robot


*** Keywords ***
Get must-gather Logs
Get Must-Gather Logs
[Documentation] Runs the must-gather image and obtains the ODH/RHOAI logs
${output}= Run process tests/Resources/CLI/MustGather/get-must-gather-logs.sh shell=yes
Should Be Equal As Integers ${output.rc} 0
Expand All @@ -27,6 +27,6 @@ Verify Logs For ${namespace}
${log_files}= Run find ${namespaces_log_dir}/${namespace}/pods -type f -name "*.log"
Should Not Be Equal ${log_files} ${EMPTY}

Cleanup must-gather Logs
Cleanup Must-Gather Logs
[Documentation] Deletes the folder with the must-gather logs
Run Keyword If "${must_gather_dir}" != "${EMPTY}" Remove Directory ${must_gather_dir} recursive=True
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,10 @@ Verify that the must-gather image provides RHODS logs and info
... MustGather
... ExcludeOnODH
... ExcludeOnDisconnected
Get must-gather Logs
Verify logs for ${APPLICATIONS_NAMESPACE}
Get Must-Gather Logs
Verify Logs For ${APPLICATIONS_NAMESPACE}
IF "${PRODUCT}" == "RHODS"
Verify Logs For ${OPERATOR_NAMESPACE}
Run Keyword If RHODS Is Managed Verify logs for ${MONITORING_NAMESPACE}
Run Keyword If RHODS Is Managed Verify Logs For ${MONITORING_NAMESPACE}
END
[Teardown] Cleanup must-gather Logs
Loading

0 comments on commit cc96d97

Please sign in to comment.