Add random metrics pipeline #1606
Open
+490
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FedeAlonso
added
the
enhancements
FedeAlonso
requested review from
jgarciao,
diegolovison,
manosnoam,
sthundat and
ConorOM1
Robot Results
|
|
Thank you @FedeAlonso for this PR. |
diegolovison
reviewed
Jul 8, 2024
|
|
||
| # In tests, we install a KFP package from the PR under test. Users should not | ||
| # normally need to specify `kfp_package_path` in their component definitions. | ||
| _KFP_PACKAGE_PATH = os.getenv('KFP_PACKAGE_PATH') |
There was a problem hiding this comment.
Is _KFP_PACKAGE_PATH required for your testing? Why do you to set it?
|
@FedeAlonso Could you check if this is needed? We have a metrics sample here: https://github.com/red-hat-data-services/ods-ci/tree/master/ods_ci/tests/Resources/Files/pipeline-samples/v2/cache-disabled/metrics If it's still needed, could you disable caching and store your pipeline in the same folder? Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a random metrics pipeline so it's easier to test the Runs (compare, metrics visualization, etc.)