Automate Validate ServiceMeshControlPlaneAlreadyCreated Test Case

ods_ci/tasks/Resources/Files/smcp_template.yml

@@ -0,0 +1,18 @@
+kind: ServiceMeshControlPlane
+apiVersion: maistra.io/v2
+metadata:
+  name: basic
+  namespace: istio-system
+spec:
+  version: v2.6
+  policy:
+    type: Istiod
+  telemetry:
+    type: Istiod
+  addons:
+    prometheus:
+      enabled: true
+    kiali:
+      enabled: true
+    grafana:
+      enabled: true

ods_ci/tasks/Resources/RHODS_OLM/install/oc_install.robot

@@ -199,7 +199,7 @@
 Install RHODS In Self Managed Cluster Using CLI
   [Documentation]   Install rhods on self managed cluster using cli
   [Arguments]     ${cluster_type}     ${image_url}
-  ${return_code}    Run and Watch Command    cd ${EXECDIR}/${OLM_DIR} && ./setup.sh -t operator -u ${UPDATE_CHANNEL} -i ${image_url} -n ${OPERATOR_NAME} -p ${OPERATOR_NAMESPACE}   timeout=20 min
+  ${return_code}    Run and Watch Command    cd ${EXECDIR}/${OLM_DIR} && ./setup.sh -t operator -u ${UPDATE_CHANNEL} -i ${image_url}   timeout=20 min
   Should Be Equal As Integers   ${return_code}   0   msg=Error detected while installing RHODS
 
 Install RHODS In Managed Cluster Using CLI

ods_ci/tests/Resources/ODS.robot

@@ -392,7 +392,7 @@ Delete RHODS Config Map
 
 Wait Until Operator Ready
     [Documentation]    Wait for operator to be available/ready
-    [Arguments]    ${operator_name}    ${namespace}    ${wait_time}=2m
+    [Arguments]    ${operator_name}    ${namespace}    ${wait_time}=10m
     ${rc}   ${output}=    Run And Return Rc And Output
     ...    oc wait --timeout=${wait_time} --for condition=available -n ${namespace} deploy/${operator_name}
     Should Be Equal    "${rc}"    "0"    msg=${output}

ods_ci/tests/Tests/0100__platform/0101__deploy/0104__operators/0104__rhods_operator/0110__service_mesh.robot

@@ -17,9 +17,13 @@
 ${SERVICE_MESH_OPERATOR_DEPLOYMENT_NAME}    istio-operator
 ${SERVICE_MESH_CR_NS}                       istio-system
 ${SERVICE_MESH_CR_NAME}                     data-science-smcp
-
-${IS_PRESENT}                           0
-${IS_NOT_PRESENT}                       1
+${OLM_DIR}                                  olm
+${RHODS_OSD_INSTALL_REPO}                   https://gitlab.cee.redhat.com/data-hub/olminstall.git
+${INSTALL_TYPE}                             CLi
+${TEST_ENV}                                 PSI
+${IS_PRESENT}                               0
+${IS_NOT_PRESENT}                           1
+${MSSG_REGEX}                               denied the request: only one service mesh may be installed per project/namespace
 
 
 *** Test Cases ***
@@ -32,7 +36,6 @@
 
     [Teardown]    Set Service Mesh State To Managed And Wait For CR Ready    ${SERVICE_MESH_CR_NAME}    ${SERVICE_MESH_CR_NS}    ${OPERATOR_NS}
 
-
 Validate Service Mesh State Unmanaged
     [Documentation]    The purpose of this Test Case is to validate Service Mesh state 'Unmanaged'.
     ...                The operator will not recreate/update the Service Mesh CR if removed or changed.
@@ -58,6 +61,28 @@
     [Teardown]    Set Service Mesh State To Managed And Wait For CR Ready
     ...           ${SERVICE_MESH_CR_NAME}    ${SERVICE_MESH_CR_NS}    ${OPERATOR_NS}
 
+Validate Service Mesh Control Plane Already Created
+    [Documentation]    This Test Case validates that only one ServiceMeshControlPlane is allowed to be installed per project/namespace
+    [Tags]      Operator        Tier3       RHOAIENG-2517
+    Fetch Image Url And Update Channel
+    Fetch Cluster Type By Domain
+    IF    "${CLUSTER_TYPE}" == "selfmanaged"
+        Uninstall RHODS In Self Managed Cluster
+        Create Smcp From Template
+        Install RHODS In Self Managed Cluster Using CLI     ${CLUSTER_TYPE}     ${IMAGE_URL}
+    ELSE IF    "${CLUSTER_TYPE}" == "managed"
+        Uninstall RHODS In OSD
+        Create Smcp From Template
+        Install RHODS In Managed Cluster Using CLI      ${CLUSTER_TYPE}     ${IMAGE_URL}
+    END
+    Operator Deployment Should Be Ready
+    # Go check the Operator logs for the error message: denied the request: only one service mesh may be installed per project/namespace
+    Verify Pod Logs Contain Error
+    # Cleanup the SMCP
+    Delete Smcp
+    # Cleanup Olminstall dir
+    Cleanup Olm Install Dir
+
 
 *** Keywords ***
 Suite Setup
@@ -70,3 +95,69 @@
 Suite Teardown
     [Documentation]    Suite Teardown
     RHOSi Teardown
+
+Fetch Image Url And Update Channel
+    [Documentation]    Fetch url for image and Update Channel
+    ${rc}    ${out}=    Run And Return Rc And Output
+    ...    oc get catalogsource rhoai-catalog-dev --namespace openshift-marketplace -o jsonpath='{.spec.image}'
+    Should Be Equal As Integers    ${rc}    0
+    Set Global Variable    ${IMAGE_URL}    ${out}
+    ${rc}    ${out}=    Run And Return Rc And Output
+    ...    oc get subscription rhoai-operator-dev --namespace redhat-ods-operator -o jsonpath='{.spec.channel}'
+    Should Be Equal As Integers    ${rc}    0
+    Set Global Variable    ${UPDATE_CHANNEL}    ${out}
+
+Fetch Cluster Type By Domain
+    [Documentation]    This Keyword outputs the kind of cluster depending on the console URL domain
+    ${matches}=    Get Regexp Matches    ${OCP_CONSOLE_URL}    rh-ods
+    ${domain}=    Get From List    ${matches}    0
+    IF    "${domain}" == "rh-ods"
+        Set Global Variable    ${CLUSTER_TYPE}    selfmanaged
+    ELSE
+        Set Global Variable    ${CLUSTER_TYPE}    managed
+    END
+
+Create Smcp From Template
+    [Documentation]    Create a default ServiceMeshControlPlane from a template
+    ${file_path}=    Set Variable    ~/work/ods-ci/ods_ci/tasks/Resources/Files/
+    ${return_code}=    Run And Return Rc    oc apply -f ${file_path}smcp_template.yml
+    Should Be Equal As Integers    ${return_code}    0
+
+Delete Smcp
+    [Documentation]    Delete the ServiceMeshControlPlane already created
+    Run and Watch Command
+    ...    oc delete ServiceMeshControlPlane basic --namespace ${SERVICE_MESH_CR_NS} --force --grace-period=0
+
+Operator Deployment Should Be Ready
+    [Documentation]    Loop until the Operator deployment is ready
+    ${rc}=    Set Variable    1
+    TRY
+        WHILE    ${rc} != 0    limit=10m
+            Sleep    5s
+            ${rc}    ${output}=    Run And Return Rc And Output
+            ...    oc wait --for condition=available -n ${OPERATOR_NAMESPACE} deploy/${OPERATOR_DEPLOYMENT_NAME}
+        END
+    EXCEPT    WHILE loop was aborted    type=start
+        Fail    msg=Operator deployment did not get ready
+    END
+
+Verify Pod Logs Contain Error
+    [Documentation]    Checks whether there is a SMCP related error on the Pod Logs
+    ${pod_name}=    Get Pod Name    ${OPERATOR_NAMESPACE}    ${OPERATOR_LABEL_SELECTOR}
+    ${pod_logs}=    Oc Get Pod Logs
+    ...    name=${pod_name}
+    ...    namespace=${OPERATOR_NAMESPACE}
+    ...    container=${OPERATOR_POD_CONTAINER_NAME}
+    ${match_list}=    Get Regexp Matches    ${pod_logs}    ${MSSG_REGEX}
+    ${entry_msg}=    Remove Duplicates    ${match_list}
+    ${length}=    Get Length    ${entry_msg}
+    IF    ${length} == ${0}
+        FAIL    Pod ${pod_name} logs should contain message ${MSSG_REGEX}.
+    ELSE
+        Log    message=Pod ${pod_name} logs contain error message '${MSSG_REGEX}'    level=INFO
+    END
+
+Cleanup Olm Install Dir
+    [Documentation]    Clean up olm install repo
+    ${return_code}=    Run and Watch Command    rm -vRf ${EXECDIR}/${OLM_DIR}    timeout=10 min
+    Should Be Equal As Integers    ${return_code}    0    msg=Error while cleaning up olminstall directory