Add ModelRegistry Namespace Check #1862
Conversation
mattmahoneyrh
added
needs testing
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
.../0100__platform/0101__deploy/0104__operators/0104__rhods_operator/0113__dsc_components.robot
Fixed
Show fixed
Hide fixed
|
|
||
| # Get expected namespace | ||
| ${rc} ${expected_namespace}= Run And Return Rc And Output | ||
| ... oc get DataScienceCluster/${DSC_NAME} -n ${OPERATOR_NS} -o "jsonpath={".spec.components.modelregistry.registriesNamespace"}" |
Check warning
Code scanning / Robocop
Line is too long ({{ line_length }}/{{ allowed_length }}) Warning test
.../0100__platform/0101__deploy/0104__operators/0104__rhods_operator/0113__dsc_components.robot
Fixed
Show fixed
Hide fixed
Robot Results
|
|
|
||
| # Get actual namespace | ||
| ${rc} ${actual_namespace}= Run And Return Rc And Output | ||
| ... oc get deployments -A | grep ${MODELREGISTRY_CONTROLLER_DEPLOYMENT_NAME} | awk '{print$1}' |
There was a problem hiding this comment.
can you use label instead of doing grep that will be more K8s way
mattmahoneyrh
requested review from
tarukumar,
MarianMacik,
CFSNM and
asanzgom
mattmahoneyrh
added
verified
|
Refactored namespace check based on clarification of expected feature behavior. |
mattmahoneyrh
removed request for
MarianMacik,
CFSNM,
tarukumar and
asanzgom
|
| [Teardown] Restore DSC Component State modelregistry ${MODELREGISTRY_CONTROLLER__DEPLOYMENT_NAME} ${MODELREGISTRY_CONTROLLER__LABEL_SELECTOR} ${SAVED_MANAGEMENT_STATES.MODELREGISTRY} | ||
|
|
||
| Validate ModelRegistry Removed State | ||
| [Documentation] Validate that ModelRegistry management state Removed does remove relevant resources. | ||
| [Tags] Operator Tier1 RHOAIENG-10404 modelregistry-removed | ||
|
|
||
| # Properly validate Removed state by first setting to Manged, which will ensure that namspace | ||
| # was created as needed for later validating that namespace persisted when component is Removed | ||
| [Setup] Set DSC Component Managed State And Wait For Completion modelregistry ${MODELREGISTRY_CONTROLLER__DEPLOYMENT_NAME} ${MODELREGISTRY_CONTROLLER__LABEL_SELECTOR} |
Check warning
Code scanning / Robocop
Line is too long ({{ line_length }}/{{ allowed_length }}) Warning test
| ... oc get DataScienceCluster/${DSC_NAME} -n ${OPERATOR_NS} -o "jsonpath={".spec.components.modelregistry.registriesNamespace"}" | ||
| Should Be Equal As Integers ${rc} 0 msg=${namespace} | ||
|
|
||
| Should Be Equal ${namespace} ${MODEL_REGISTRY_NAMESPACE} msg=Model Registry Namespace: Actual "${namespace}" Expected: "${MODEL_REGISTRY_NAMESPACE}" |
Check warning
Code scanning / Robocop
Line is too long ({{ line_length }}/{{ allowed_length }}) Warning test
|
|
||
| ${rc} ${output}= Run And Return Rc And Output | ||
| ... oc get namespace -A ${MODEL_REGISTRY_NAMESPACE} | ||
| Should Be Equal As Integers ${rc} 0 msg=${output} |
Check warning
Code scanning / Robocop
File has too many lines ({{ lines_count }}/{{max_allowed_count }}) Warning test
mattmahoneyrh
requested review from
tarukumar,
MarianMacik,
CFSNM and
asanzgom
Add ModelRegistry check to validate the appropriate namespace is created for ODH and RHOAI.
Validate that namespace is not deleted when management state is set to Removed.
RHOAIENG-12703