Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the Python version and other requirements for the 2024b OOTB images #1870

Merged
merged 2 commits into from
Oct 7, 2024

Conversation

jstourac
Copy link
Member

@jstourac jstourac commented Sep 30, 2024

These changes are required for the testing of the recently updated 2024b images added with the RHOAI 2.14 release.

These images also contains new Jupyter 4 and Elyra 4 version, see [1].

Another change in this PR is a removal of the simple test for Habana image as that image is removed in 2.14. This change is to comply with this issue [2].


CI:
image

@@ -82,7 +81,7 @@
Maybe Close Popup
${is_launcher_selected} = Run Keyword And Return Status JupyterLab Launcher Tab Is Selected
IF not ${is_launcher_selected} Open JupyterLab Launcher
Launch a new JupyterLab Document kernel=Python 3.9
Launch a new JupyterLab Document kernel=Python 3.11

Check warning

Code scanning / Robocop

Keyword name '{{ keyword_name }}' does not follow case convention Warning test

Keyword name 'Launch a new JupyterLab Document' does not follow case convention
Copy link
Contributor

github-actions bot commented Sep 30, 2024

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass %
547 0 0 547 100

jiridanek
jiridanek previously approved these changes Sep 30, 2024
@jstourac jstourac force-pushed the 2024bImages branch 2 times, most recently from 8489f8a to a21802f Compare October 7, 2024 09:32
…mages

These changes are required for the testing of the recently updated 2024b
images added with the RHOAI 2.14 release.

These images also contains new Jupyter 4 and Elyra 4 version, see [1].

* [1] https://issues.redhat.com/browse/RHOAIENG-11697
Copy link

sonarqubecloud bot commented Oct 7, 2024

@jstourac jstourac self-assigned this Oct 7, 2024
@jstourac jstourac marked this pull request as ready for review October 7, 2024 11:08
[Documentation] Replace current selectors with JupyterLab 3-specific ones.
... This is the custom implementation since the original one doesn't really
... reverts defaults if they had been set to Jupyter 4 in the past already.
Set Global Variable ${CM VERSION} ${5}

Check notice

Code scanning / Robocop

{{ set_variable_keyword }} can be replaced with VAR Note test

Set Global Variable can be replaced with VAR
... This is the custom implementation since the original one doesn't really
... reverts defaults if they had been set to Jupyter 4 in the past already.
Set Global Variable ${CM VERSION} ${5}
Set Global Variable ${CM CSS EDITOR} .CodeMirror

Check notice

Code scanning / Robocop

{{ set_variable_keyword }} can be replaced with VAR Note test

Set Global Variable can be replaced with VAR
... reverts defaults if they had been set to Jupyter 4 in the past already.
Set Global Variable ${CM VERSION} ${5}
Set Global Variable ${CM CSS EDITOR} .CodeMirror
Set Global Variable ${CM JS INSTANCE} .CodeMirror

Check notice

Code scanning / Robocop

{{ set_variable_keyword }} can be replaced with VAR Note test

Set Global Variable can be replaced with VAR
Set Global Variable ${CM VERSION} ${5}
Set Global Variable ${CM CSS EDITOR} .CodeMirror
Set Global Variable ${CM JS INSTANCE} .CodeMirror
Set Global Variable ${JLAB CSS ACTIVE INPUT} ${JLAB CSS ACTIVE CELL} ${CM CSS EDITOR}

Check notice

Code scanning / Robocop

{{ set_variable_keyword }} can be replaced with VAR Note test

Set Global Variable can be replaced with VAR
@jstourac jstourac added verified This PR has been tested with Jenkins enhancements Bugfixes, enhancements, refactoring, ... in tests or libraries (PR will be listed in release-notes) labels Oct 7, 2024
@jstourac jstourac requested review from lugi0 and bdattoma October 7, 2024 11:12
@jstourac jstourac enabled auto-merge (rebase) October 7, 2024 11:15
@jstourac jstourac merged commit 6c5a7b7 into red-hat-data-services:master Oct 7, 2024
8 checks passed
@jstourac jstourac deleted the 2024bImages branch October 7, 2024 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancements Bugfixes, enhancements, refactoring, ... in tests or libraries (PR will be listed in release-notes) verified This PR has been tested with Jenkins
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants