-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "New KW Wait For Deployment Replica To Be Ready
for oc_install.robot" because discussion was not done
#1872
Conversation
…ll.robot…" This reverts commit fb48468.
Quality Gate passedIssues Measures |
... namespace=${APPLICATIONS_NAMESPACE} | ||
... label_selector=component=model-mesh-etcd | ||
... timeout=400 | ||
Log To Console "Waiting for 3 pods in ${APPLICATIONS_NAMESPACE}, label_selector=app.kubernetes.io/name=modelmesh-controller" |
Check warning
Code scanning / Robocop
Line is too long ({{ line_length }}/{{ allowed_length }}) Warning
${datasciencepipelines} = Is Component Enabled datasciencepipelines ${DSC_NAME} | ||
IF ("${UPDATE_CHANNEL}" == "stable" or "${UPDATE_CHANNEL}" == "beta") or "${datasciencepipelines}" == "true" | ||
Wait For Deployment Replica To Be Ready namespace=${APPLICATIONS_NAMESPACE} | ||
... label_selector=app.kubernetes.io/name=data-science-pipelines-operator timeout=400s | ||
Log To Console "Waiting for 1 pod in ${APPLICATIONS_NAMESPACE}, label_selector=app.kubernetes.io/name=data-science-pipelines-operator" |
Check warning
Code scanning / Robocop
Line is too long ({{ line_length }}/{{ allowed_length }}) Warning
${modelregistry} = Is Component Enabled modelregistry ${DSC_NAME} | ||
IF "${modelregistry}" == "true" | ||
Wait For Deployment Replica To Be Ready namespace=${APPLICATIONS_NAMESPACE} | ||
... label_selector=app.kubernetes.io/part-of=model-registry-operator timeout=400s | ||
Log To Console "Waiting for 1 pod in ${APPLICATIONS_NAMESPACE}, label_selector=app.kubernetes.io/part-of=model-registry-operator" |
Check warning
Code scanning / Robocop
Line is too long ({{ line_length }}/{{ allowed_length }}) Warning
... namespace=${APPLICATIONS_NAMESPACE} | ||
... label_selector=app=odh-model-controller | ||
... timeout=400 | ||
Log To Console "Waiting for 1 pods in ${APPLICATIONS_NAMESPACE}, label_selector=control-plane=kserve-controller-manager" |
Check warning
Code scanning / Robocop
Line is too long ({{ line_length }}/{{ allowed_length }}) Warning
Robot Results
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving this in case we decided we want to revert this before the true and proper tests are implemented elsewhere.
It would be also nice to enrich this with the extra commit amending the number of expected pods for the odh-model-controller
from 3 to 1 on those two places where it is checked here. But can be also as a separate PR.
Reverts #1867