Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test Case check for correct component images #1965

Conversation

asanzgom
Copy link
Contributor

New Test Case to check for correct component images



*** Test Cases ***
Check For Correct Component Images

Check warning

Code scanning / Robocop

Test case '{{ test_name }}' has too many keywords inside ({{ keyword_count }}/{{ max_allowed_count }}) Warning test

Test case 'Check For Correct Component Images' has too many keywords inside (12/10)
Copy link
Contributor

github-actions bot commented Oct 25, 2024

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass %
560 0 0 560 100

@asanzgom
Copy link
Contributor Author

Triggered /rhods-ci-pr-test/3398

@asanzgom
Copy link
Contributor Author

rhods-ci-pr-test/3417 passed succesfully

@asanzgom asanzgom requested review from bdattoma and CFSNM October 28, 2024 11:36
@asanzgom asanzgom requested a review from CFSNM October 28, 2024 12:13
CFSNM
CFSNM previously approved these changes Oct 28, 2024
@asanzgom asanzgom enabled auto-merge October 28, 2024 12:16
[Documentation] The purpose is to enforce the check of correct component images on their deployments.
[Tags] Operator RHOAIENG-12576 Smoke
[Template] Check Image On Csv And Deployment
codeflare codeflare-operator-manager odh_codeflare_operator_image

Check warning

Code scanning / Robocop

Trailing whitespace at the end of line Warning test

Trailing whitespace at the end of line
[Tags] Operator RHOAIENG-12576 Smoke
[Template] Check Image On Csv And Deployment
codeflare codeflare-operator-manager odh_codeflare_operator_image
modelregistry model-registry-operator-controller-manager odh_mlmd_grpc_server_image

Check warning

Code scanning / Robocop

Trailing whitespace at the end of line Warning test

Trailing whitespace at the end of line
[Template] Check Image On Csv And Deployment
codeflare codeflare-operator-manager odh_codeflare_operator_image
modelregistry model-registry-operator-controller-manager odh_mlmd_grpc_server_image
modelregistry model-registry-operator-controller-manager odh_model_registry_image

Check warning

Code scanning / Robocop

Trailing whitespace at the end of line Warning test

Trailing whitespace at the end of line
modelregistry model-registry-operator-controller-manager odh_mlmd_grpc_server_image
modelregistry model-registry-operator-controller-manager odh_model_registry_image
trustyai trustyai-service-operator-controller-manager odh_trustyai_service_operator_image
ray kuberay-operator odh_kuberay_operator_controller_image

Check warning

Code scanning / Robocop

Line is too long ({{ line_length }}/{{ allowed_length }}) Warning test

Line is too long (121/120)
kueue kueue-controller-manager odh_kueue_controller_image
workbenches odh-notebook-controller-manager odh_notebook_controller_image
workbenches notebook-controller-deployment odh_kf_notebook_controller_image
dashboard ${DASHBOARD_DEPLOYMENT_NAME} odh_dashboard_image

Check warning

Code scanning / Robocop

Trailing whitespace at the end of line Warning test

Trailing whitespace at the end of line
workbenches notebook-controller-deployment odh_kf_notebook_controller_image
dashboard ${DASHBOARD_DEPLOYMENT_NAME} odh_dashboard_image
modelmeshserving modelmesh-controller odh_modelmesh_controller_image
datasciencepipelines data-science-pipelines-operator-controller-manager odh_data_science_pipelines_operator_controller_image

Check warning

Code scanning / Robocop

Line is too long ({{ line_length }}/{{ allowed_length }}) Warning test

Line is too long (136/120)
[Arguments] ${component} ${deployment_name} ${image}

${rc} ${managementState}= Run And Return Rc And Output
... oc get DataScienceCluster default-dsc -o jsonpath="{.spec.components['${component}'].managementState}"

Check warning

Code scanning / Robocop

Continuation marker should be aligned with starting row Warning test

Continuation marker should be aligned with starting row
IF "${managementState}" == "Managed"

${rc} ${csv_image}= Run And Return Rc And Output
... oc get ClusterServiceVersion -l ${OPERATOR_SUBSCRIPTION_LABEL} -n ${OPERATOR_NAMESPACE} -o jsonpath='{.items[?(@.kind=="ClusterServiceVersion")].spec.relatedImages[?(@.name=="${image}")].image}'

Check warning

Code scanning / Robocop

Line is too long ({{ line_length }}/{{ allowed_length }}) Warning test

Line is too long (209/120)
Should Not Be Empty ${csv_image}
Log To Console IMAGE ON CSV IS ${csv_image}

${rc} ${out}= Run And Return Rc And Output

Check notice

Code scanning / Robocop

Variable '{{ name }}' is assigned but not used Note test

Variable '${out}' is assigned but not used
Log To Console IMAGE ON CSV IS ${csv_image}

${rc} ${out}= Run And Return Rc And Output
... oc get Deployment ${deployment_name} -n ${APPLICATIONS_NAMESPACE} -o jsonpath='{.spec.template.spec.containers[?(@.images=="${csv_image}")]}'

Check warning

Code scanning / Robocop

Line is too long ({{ line_length }}/{{ allowed_length }}) Warning test

Line is too long (156/120)
@asanzgom asanzgom requested a review from FedeAlonso October 28, 2024 15:27
Copy link

@asanzgom
Copy link
Contributor Author

kudos to @FedeAlonso for his advice on how to implement RF Templates!

@asanzgom
Copy link
Contributor Author

rhods-ci-pr-test/3419 passed succesfully

@asanzgom asanzgom requested a review from CFSNM October 28, 2024 15:47
@asanzgom asanzgom merged commit bf29e2a into red-hat-data-services:master Oct 28, 2024
8 checks passed
@asanzgom asanzgom deleted the feature/check_correct_component_images branch October 28, 2024 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants