Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added FIL model REST protocol test on triton for Kserve #2018

Merged
merged 15 commits into from
Dec 4, 2024
Merged

Added FIL model REST protocol test on triton for Kserve #2018

merged 15 commits into from
Dec 4, 2024

Conversation

rpancham
Copy link
Contributor

No description provided.

github-advanced-security[bot]
github-advanced-security bot found potential problems Nov 12, 2024
View reviewed changes
...odel_serving/1009__model_serving_triton_on_kserve/1009__model_serving_triton_on_kserve.robot Fixed Show fixed Hide fixed
...odel_serving/1009__model_serving_triton_on_kserve/1009__model_serving_triton_on_kserve.robot
@@ -208,6 +214,52 @@
... AND
... Delete Serving Runtime Template From CLI displayed_name=triton-tensorflow-grpc

Test KERAS Model Grpc Inference Via UI (Triton on Kserve) # robocop: off=too-long-test-case

Check warning

Code scanning / Robocop

Test case '{{ test_name }}' has too many keywords inside ({{ keyword_count }}/{{ max_allowed_count }}) Warning test

Test case 'Test KERAS Model Grpc Inference Via UI (Triton on Kserve)' has too many keywords inside (22/10)
...odel_serving/1009__model_serving_triton_on_kserve/1009__model_serving_triton_on_kserve.robot
... aws_access_key=${S3.AWS_ACCESS_KEY_ID} aws_secret_access=${S3.AWS_SECRET_ACCESS_KEY}
... aws_bucket_name=ods-ci-s3
Deploy Kserve Model Via UI model_name=${PYTORCH_MODEL_NAME} serving_runtime=triton-keras-grpc
... data_connection=model-serving-connection path=tritonkeras/model_repository/ model_framework=tensorflow - 2

Check warning

Code scanning / Robocop

Line is too long ({{ line_length }}/{{ allowed_length }}) Warning test

Line is too long (123/120)
...odel_serving/1009__model_serving_triton_on_kserve/1009__model_serving_triton_on_kserve.robot
... token=${TRUE}
Wait For Pods To Be Ready label_selector=serving.kserve.io/inferenceservice=${PYTORCH_MODEL_NAME}
... namespace=${PRJ_TITLE}
${EXPECTED_INFERENCE_GRPC_OUTPUT_KERAS}= Load Json File file_path=${EXPECTED_INFERENCE_GRPC_OUTPUT_FILE_KERAS}

Check warning

Code scanning / Robocop

Line is too long ({{ line_length }}/{{ allowed_length }}) Warning test

Line is too long (122/120)
...odel_serving/1009__model_serving_triton_on_kserve/1009__model_serving_triton_on_kserve.robot
... Clean All Models Of Current User
... AND
... Delete Serving Runtime Template From CLI displayed_name=triton-kserve-rest

Check warning

Code scanning / Robocop

Invalid number of empty lines between sections ({{ empty_lines }}/{{ allowed_empty_lines }}) Warning test

Invalid number of empty lines between sections (1/2)
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 12, 2024 •
edited
Loading

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass %
584 0 0 584 100

@rpancham rpancham added new test New test(s) added (PR will be listed in release-notes) do not merge Do not merge this yet please labels Nov 14, 2024
github-advanced-security[bot]
github-advanced-security bot found potential problems Dec 3, 2024
View reviewed changes
...odel_serving/1009__model_serving_triton_on_kserve/1009__model_serving_triton_on_kserve.robot
${INFERENCE_GRPC_INPUT_KERAS}= tests/Resources/Files/triton/kserve-triton-keras-gRPC-input.json
${EXPECTED_INFERENCE_GRPC_OUTPUT_FILE_KERAS}= tests/Resources/Files/triton/kserve-triton-keras-gRPC-output.json
${FIL_MODEL_NAME}= fil
${FIL_RUNTIME_NAME_REST}= triton-fil-rest

Check notice

Code scanning / Robocop

Variable '{{ name }}' is assigned but not used Note test

Variable '${FIL_RUNTIME_NAME_REST}' is assigned but not used
@rpancham
Copy link
Contributor Author

rpancham commented Dec 3, 2024

Verified with build 1927

Raghul-M
Raghul-M previously approved these changes Dec 3, 2024
View reviewed changes
@rpancham rpancham added verified This PR has been tested with Jenkins and removed do not merge Do not merge this yet please labels Dec 3, 2024
@bdattoma bdattoma mentioned this pull request Dec 3, 2024
Merged
@rpancham rpancham requested a review from bdattoma December 3, 2024 15:04
github-advanced-security[bot]
github-advanced-security bot found potential problems Dec 3, 2024
View reviewed changes
...odel_serving/1009__model_serving_triton_on_kserve/1009__model_serving_triton_on_kserve.robot
Log ${inference_output}
${inference_output}= Evaluate json.dumps(${inference_output})
Log ${inference_output}
${result} ${list}= Inference Comparison ${EXPECTED_INFERENCE_GRPC_OUTPUT_KERAS} ${inference_output}

Check notice

Code scanning / Robocop

Variable '{{ name }}' is assigned but not used Note test

Variable '${result}' is assigned but not used
...odel_serving/1009__model_serving_triton_on_kserve/1009__model_serving_triton_on_kserve.robot
Log ${inference_output}
${inference_output}= Evaluate json.dumps(${inference_output})
Log ${inference_output}
${result} ${list}= Inference Comparison ${EXPECTED_INFERENCE_GRPC_OUTPUT_KERAS} ${inference_output}

Check notice

Code scanning / Robocop

Variable '{{ name }}' is assigned but not used Note test

Variable '${list}' is assigned but not used
@rpancham rpancham requested a review from Raghul-M December 4, 2024 04:42
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Dec 4, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@tarukumar tarukumar enabled auto-merge (squash) December 4, 2024 05:10
@tarukumar tarukumar merged commit 9455e23 into red-hat-data-services:master Dec 4, 2024
9 checks passed
rpancham added a commit to rpancham/ods-ci that referenced this pull request Dec 9, 2024
@rpancham @tarukumar
Added FIL model REST protocol test on triton for Kserve (red-hat-data…
762e06a 
…-services#2018)

Co-authored-by: Tarun Kumar <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tarukumar tarukumar tarukumar approved these changes

@Raghul-M Raghul-M Raghul-M approved these changes

@bdattoma bdattoma Awaiting requested review from bdattoma

Assignees
No one assigned
Labels
new test New test(s) added (PR will be listed in release-notes) verified This PR has been tested with Jenkins
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rpancham @Raghul-M @bdattoma @tarukumar