enhancement: improve component readiness check when operator is being installed part 2 #2031
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Robot Results
|
CFSNM
force-pushed
the
component_check_part_2
branch
4 times, most recently
from
a7b907a to
d2a545b
Compare
bdattoma
reviewed
Nov 15, 2024
| @@ -178,7 +178,7 @@ Verify RHODS Installation | |||
| ... label_selector=app.kubernetes.io/part-of=trainingoperator timeout=400s | |||
| END | |||
|
|
|||
| IF "${dashboard}" == "true" or "${workbenches}" == "true" or "${modelmeshserving}" == "true" or "${datasciencepipelines}" == "true" or "${kserve}" == "true" or "${kueue}" == "true" or "${codeflare}" == "true" or "${ray}" == "true" or "${trustyai}" == "true" or "${modelregistry}" == "true" or "${trainingoperator}" == "true" # robocop: disable | |||
| IF "${dashboard}" == "true" or "${workbenches}" == "true" or "${modelmeshserving}" == "true" or "${datasciencepipelines}" == "true" or "${kserve}" == "true" or "${kueue}" == "true" or "${codeflare}" == "true" or "${ray}" == "true" or "${trustyai}" == "true" or "${modelregistry}" == "true" or "${trainingoperator}" == "true" # robocop: disable | |||
There was a problem hiding this comment.
damn, I did a rebase and lost all the changes. Will fix it next week
bdattoma
reviewed
Nov 15, 2024
| @@ -178,7 +178,7 @@ Verify RHODS Installation | |||
| ... label_selector=app.kubernetes.io/part-of=trainingoperator timeout=400s | |||
| END | |||
|
|
|||
| IF "${dashboard}" == "true" or "${workbenches}" == "true" or "${modelmeshserving}" == "true" or "${datasciencepipelines}" == "true" or "${kserve}" == "true" or "${kueue}" == "true" or "${codeflare}" == "true" or "${ray}" == "true" or "${trustyai}" == "true" or "${modelregistry}" == "true" or "${trainingoperator}" == "true" # robocop: disable | |||
| IF "${dashboard}" == "true" or "${workbenches}" == "true" or "${modelmeshserving}" == "true" or "${datasciencepipelines}" == "true" or "${kserve}" == "true" or "${kueue}" == "true" or "${codeflare}" == "true" or "${ray}" == "true" or "${trustyai}" == "true" or "${modelregistry}" == "true" or "${trainingoperator}" == "true" # robocop: disable | |||
| Log To Console Waiting for pod status in ${APPLICATIONS_NAMESPACE} | |||
| Wait For Pods Status namespace=${APPLICATIONS_NAMESPACE} timeout=200 | |||
| Log Verified Applications NS: ${APPLICATIONS_NAMESPACE} console=yes | |||
There was a problem hiding this comment.
damn, I did a rebase and lost all the changes. Will fix it next week
… installed part 2
CFSNM
force-pushed
the
component_check_part_2
branch
from
d2a545b to
2fc2a3b
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up PR for #2016
Adding @bdattoma suggestions: