Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DW: Add test coverage for custom ROCm Ray image #2124

Merged
merged 1 commit into from
Dec 10, 2024
Merged

DW: Add test coverage for custom ROCm Ray image #2124

merged 1 commit into from
Dec 10, 2024

Conversation

ChughShilpa
Copy link
Contributor

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 9, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

github-advanced-security[bot]
github-advanced-security bot found potential problems Dec 9, 2024
View reviewed changes
ods_ci/tests/Resources/Page/DistributedWorkloads/DistributedWorkloads.resource
@@ -16,6 +16,8 @@
${RAY_TORCH_CUDA_IMAGE_3.11} quay.io/rhoai/ray@sha256:5077f9bb230dfa88f34089fecdfcdaa8abc6964716a8a8325c7f9dcdf11bbbb3
# Corresponds to quay.io/modh/ray:2.35.0-py311-rocm61
${RAY_ROCM_IMAGE_3.11} quay.io/modh/ray@sha256:f8b4f2b1c954187753c1f5254f7bb6a4286cec5a4f1b43def7ef4e009f2d28cb
# Corresponds to quay.io/rhoai/ray:2.35.0-py311-rocm61-torch24-fa26
${RAY_TORCH_ROCM_IMAGE_3.11} quay.io/rhoai/ray@sha256:b0e129cd2f4cdea7ad7a7859031357ffd9915410551f94fbcb942af2198cdf78

Check warning

Code scanning / Robocop

Line is too long ({{ line_length }}/{{ allowed_length }}) Warning test

Line is too long (130/120)
ods_ci/tests/Tests/0600__distributed_workloads/test-run-distributed-workloads-tests.robot
@@ -55,21 +55,41 @@
... WorkloadsOrchestration
Run DistributedWorkloads ODH Test TestMnistRayTuneHpoGpu ${RAY_CUDA_IMAGE_3.11} ${NOTEBOOK_IMAGE_3.11}

Run TestKueueCustomRayCpu ODH test with Python 3.11
[Documentation] Run Go ODH test: TestKueueCustomRayCpu
Run TestKueueCustomRayCudaCpu ODH test with Python 3.11

Check warning

Code scanning / Robocop

Not allowed character '{{ character }}' found in {{ block_name }} name Warning test

Not allowed character '.' found in 'Run TestKueueCustomRayCudaCpu ODH test with Python 3.11' test case name
ods_ci/tests/Tests/0600__distributed_workloads/test-run-distributed-workloads-tests.robot
[Tags] RHOAIENG-10013
... Tier1
... DistributedWorkloads
... Training
... WorkloadsOrchestration
Run DistributedWorkloads ODH Test TestMnistCustomRayImageCpu ${RAY_TORCH_CUDA_IMAGE_3.11} ${NOTEBOOK_IMAGE_3.11}
Run DistributedWorkloads ODH Test TestMnistCustomRayCudaCpu ${RAY_TORCH_CUDA_IMAGE_3.11} ${NOTEBOOK_IMAGE_3.11}

Check warning

Code scanning / Robocop

Line is too long ({{ line_length }}/{{ allowed_length }}) Warning test

Line is too long (124/120)
ods_ci/tests/Tests/0600__distributed_workloads/test-run-distributed-workloads-tests.robot

Run TestKueueCustomRayGpu ODH test with Python 3.11
[Documentation] Run Go ODH test: TestKueueCustomRayGpu
Run TestKueueCustomRayCudaGpu ODH test with Python 3.11

Check warning

Code scanning / Robocop

Not allowed character '{{ character }}' found in {{ block_name }} name Warning test

Not allowed character '.' found in 'Run TestKueueCustomRayCudaGpu ODH test with Python 3.11' test case name
ods_ci/tests/Tests/0600__distributed_workloads/test-run-distributed-workloads-tests.robot
[Tags] RHOAIENG-10013
... Resources-GPU NVIDIA-GPUs
... Tier1
... DistributedWorkloads
... Training
... WorkloadsOrchestration
Run DistributedWorkloads ODH Test TestMnistCustomRayImageGpu ${RAY_TORCH_CUDA_IMAGE_3.11} ${NOTEBOOK_IMAGE_3.11}
Run DistributedWorkloads ODH Test TestMnistCustomRayCudaGpu ${RAY_TORCH_CUDA_IMAGE_3.11} ${NOTEBOOK_IMAGE_3.11}

Check warning

Code scanning / Robocop

Line is too long ({{ line_length }}/{{ allowed_length }}) Warning test

Line is too long (124/120)
ods_ci/tests/Tests/0600__distributed_workloads/test-run-distributed-workloads-tests.robot
Run DistributedWorkloads ODH Test TestMnistCustomRayImageGpu ${RAY_TORCH_CUDA_IMAGE_3.11} ${NOTEBOOK_IMAGE_3.11}
Run DistributedWorkloads ODH Test TestMnistCustomRayCudaGpu ${RAY_TORCH_CUDA_IMAGE_3.11} ${NOTEBOOK_IMAGE_3.11}

Run TestKueueCustomRayRocmCpu ODH test with Python 3.11

Check warning

Code scanning / Robocop

Not allowed character '{{ character }}' found in {{ block_name }} name Warning test

Not allowed character '.' found in 'Run TestKueueCustomRayRocmCpu ODH test with Python 3.11' test case name
ods_ci/tests/Tests/0600__distributed_workloads/test-run-distributed-workloads-tests.robot
... DistributedWorkloads
... Training
... WorkloadsOrchestration
Run DistributedWorkloads ODH Test TestMnistCustomRayRocmCpu ${RAY_TORCH_ROCM_IMAGE_3.11} ${NOTEBOOK_IMAGE_3.11}

Check warning

Code scanning / Robocop

Line is too long ({{ line_length }}/{{ allowed_length }}) Warning test

Line is too long (124/120)
ods_ci/tests/Tests/0600__distributed_workloads/test-run-distributed-workloads-tests.robot
... WorkloadsOrchestration
Run DistributedWorkloads ODH Test TestMnistCustomRayRocmCpu ${RAY_TORCH_ROCM_IMAGE_3.11} ${NOTEBOOK_IMAGE_3.11}

Run TestKueueCustomRayRocmGpu ODH test with Python 3.11

Check warning

Code scanning / Robocop

Not allowed character '{{ character }}' found in {{ block_name }} name Warning test

Not allowed character '.' found in 'Run TestKueueCustomRayRocmGpu ODH test with Python 3.11' test case name
ods_ci/tests/Tests/0600__distributed_workloads/test-run-distributed-workloads-tests.robot
... DistributedWorkloads
... Training
... WorkloadsOrchestration
Run DistributedWorkloads ODH Test TestMnistCustomRayRocmGpu ${RAY_TORCH_ROCM_IMAGE_3.11} ${NOTEBOOK_IMAGE_3.11}

Check warning

Code scanning / Robocop

Line is too long ({{ line_length }}/{{ allowed_length }}) Warning test

Line is too long (124/120)
abhijeet-dhumal
abhijeet-dhumal reviewed Dec 9, 2024
View reviewed changes
Copy link
Contributor

@abhijeet-dhumal abhijeet-dhumal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 9, 2024

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass %
588 0 0 588 100

@ChughShilpa
Copy link
Contributor Author

Test passed in rhoai-test-flow/2044

@sutaakar sutaakar merged commit f4a85a2 into red-hat-data-services:master Dec 10, 2024
11 checks passed
@ChughShilpa ChughShilpa deleted the RHOAIENG-12484 branch December 10, 2024 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abhijeet-dhumal abhijeet-dhumal abhijeet-dhumal left review comments

@sutaakar sutaakar sutaakar approved these changes

@jiripetrlik jiripetrlik jiripetrlik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ChughShilpa @sutaakar @jiripetrlik @abhijeet-dhumal