-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build ODS-CI test image on release-2.13 branch #2125
Conversation
Robot Results
|
@@ -0,0 +1,21 @@ | |||
export SET_ENVIRONMENT=1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ARTIFACT_DIR="/tmp" | ||
fi | ||
|
||
poetry run robot --include ${TEST_SUITE} -d ${ARTIFACT_DIR} -x xunit_test_result.xml -r test_report.html --variablefile ${TEST_VARIABLES_FILE} ${TEST_CASE_FILE} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ARTIFACT_DIR="/tmp" | ||
fi | ||
|
||
poetry run robot --include ${TEST_SUITE} -d ${ARTIFACT_DIR} -x xunit_test_result.xml -r test_report.html --variablefile ${TEST_VARIABLES_FILE} ${TEST_CASE_FILE} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit
shellcheck
Quote to prevent word splitting/globbing, or split robustly with mapfile or read -a. SC2206
ods-ci/ods_ci/build/install_idp.sh
Line 46 in 7ef9f15
USERS_ARR+=($prefix$additional_base_suffix) |
Quote to prevent word splitting/globbing, or split robustly with mapfile or read -a. SC2206
ods-ci/ods_ci/build/install_idp.sh
Line 46 in 7ef9f15
USERS_ARR+=($prefix$additional_base_suffix) |
Quote to prevent word splitting/globbing, or split robustly with mapfile or read -a. SC2206
ods-ci/ods_ci/build/install_idp.sh
Line 47 in 7ef9f15
PWS_ARR+=($pw) |
Quote to prevent word splitting/globbing, or split robustly with mapfile or read -a. SC2206
ods-ci/ods_ci/build/install_idp.sh
Line 50 in 7ef9f15
USERS_ARR+=($prefix$additional_base_suffix$i) |
Quote to prevent word splitting/globbing, or split robustly with mapfile or read -a. SC2206
ods-ci/ods_ci/build/install_idp.sh
Line 50 in 7ef9f15
USERS_ARR+=($prefix$additional_base_suffix$i) |
Quote to prevent word splitting/globbing, or split robustly with mapfile or read -a. SC2206
ods-ci/ods_ci/build/install_idp.sh
Line 50 in 7ef9f15
USERS_ARR+=($prefix$additional_base_suffix$i) |
Quote to prevent word splitting/globbing, or split robustly with mapfile or read -a. SC2206
ods-ci/ods_ci/build/install_idp.sh
Line 51 in 7ef9f15
PWS_ARR+=($pw) |
📝 [shellcheck] reported by reviewdog 🐶
Double quote to prevent globbing and word splitting. SC2086
ods-ci/ods_ci/build/install_idp.sh
Line 58 in 7ef9f15
suffixes=$(echo $suffix_info | jq -c '.list[]') |
Quote to prevent word splitting/globbing, or split robustly with mapfile or read -a. SC2206
ods-ci/ods_ci/build/install_idp.sh
Line 59 in 7ef9f15
declare -a suffixes_arr=($suffixes) |
📝 [shellcheck] reported by reviewdog 🐶
Double quote to prevent globbing and word splitting. SC2086
ods-ci/ods_ci/build/install_idp.sh
Line 63 in 7ef9f15
quotes_flag=$(echo $suffix | egrep -o '".+"') |
📝 [shellcheck] reported by reviewdog 🐶
egrep is non-standard and deprecated. Use grep -E instead. SC2196
ods-ci/ods_ci/build/install_idp.sh
Line 63 in 7ef9f15
quotes_flag=$(echo $suffix | egrep -o '".+"') |
📝 [shellcheck] reported by reviewdog 🐶
Double quote to prevent globbing and word splitting. SC2086
ods-ci/ods_ci/build/install_idp.sh
Line 65 in 7ef9f15
complete_name=$(echo $complete_name | tr -d '"') |
Quote to prevent word splitting/globbing, or split robustly with mapfile or read -a. SC2206
ods-ci/ods_ci/build/install_idp.sh
Line 67 in 7ef9f15
USERS_ARR+=($complete_name) |
Quote to prevent word splitting/globbing, or split robustly with mapfile or read -a. SC2206
ods-ci/ods_ci/build/install_idp.sh
Line 68 in 7ef9f15
PWS_ARR+=($pw) |
📝 [shellcheck] reported by reviewdog 🐶
Double quote to prevent globbing and word splitting. SC2086
ods-ci/ods_ci/build/install_idp.sh
Line 73 in 7ef9f15
test_user_mapping=$(jq -r --arg idpname $1 --arg test_user $2 '.[][$idpname][$test_user]' configs/templates/user_config.json) |
📝 [shellcheck] reported by reviewdog 🐶
Double quote to prevent globbing and word splitting. SC2086
ods-ci/ods_ci/build/install_idp.sh
Line 73 in 7ef9f15
test_user_mapping=$(jq -r --arg idpname $1 --arg test_user $2 '.[][$idpname][$test_user]' configs/templates/user_config.json) |
[shellcheck] reported by reviewdog 🐶
Useless echo? Instead of 'cmd $(echo foo)', just use 'cmd foo'. SC2116
ods-ci/ods_ci/build/install_idp.sh
Line 76 in 7ef9f15
test_user_regex=$(echo "${test_user_mapping/<RAND_BASE>/"[a-zA-Z]+"}") |
📝 [shellcheck] reported by reviewdog 🐶
Double quote to prevent globbing and word splitting. SC2086
ods-ci/ods_ci/build/install_idp.sh
Line 77 in 7ef9f15
test_user_mapping=$(echo $users_string | egrep -o "$test_user_regex(,|$)" | tr -d ",") |
📝 [shellcheck] reported by reviewdog 🐶
egrep is non-standard and deprecated. Use grep -E instead. SC2196
ods-ci/ods_ci/build/install_idp.sh
Line 77 in 7ef9f15
test_user_mapping=$(echo $users_string | egrep -o "$test_user_regex(,|$)" | tr -d ",") |
📝 [shellcheck] reported by reviewdog 🐶
Double quote to prevent globbing and word splitting. SC2086
ods-ci/ods_ci/build/install_idp.sh
Line 78 in 7ef9f15
echo $test_user_mapping |
📝 [shellcheck] reported by reviewdog 🐶
Double quote to prevent globbing and word splitting. SC2086
ods-ci/ods_ci/build/install_idp.sh
Line 80 in 7ef9f15
echo $test_user_mapping |
📝 [shellcheck] reported by reviewdog 🐶
Double quote to prevent globbing and word splitting. SC2086
ods-ci/ods_ci/build/install_idp.sh
Line 85 in 7ef9f15
idp=$(jq --arg idpname $1 '.[][$idpname]' configs/templates/user_config.json) |
📝 [shellcheck] reported by reviewdog 🐶
Double quote to prevent globbing and word splitting. SC2086
ods-ci/ods_ci/build/install_idp.sh
Line 88 in 7ef9f15
pw=$(echo $idp | jq -r '.pw') |
📝 [shellcheck] reported by reviewdog 🐶
Double quote to prevent globbing and word splitting. SC2086
ods-ci/ods_ci/build/install_idp.sh
Line 94 in 7ef9f15
echo Random $1 pasword: $pw |
📝 [shellcheck] reported by reviewdog 🐶
Double quote to prevent globbing and word splitting. SC2086
ods-ci/ods_ci/build/install_idp.sh
Line 94 in 7ef9f15
echo Random $1 pasword: $pw |
📝 [shellcheck] reported by reviewdog 🐶
Double quote to prevent globbing and word splitting. SC2086
ods-ci/ods_ci/build/install_idp.sh
Line 97 in 7ef9f15
prefixes=$(echo $idp | jq --raw-output '.prefixes[]') |
Quote to prevent word splitting/globbing, or split robustly with mapfile or read -a. SC2206
ods-ci/ods_ci/build/install_idp.sh
Line 98 in 7ef9f15
prefixes=($prefixes) |
📝 [shellcheck] reported by reviewdog 🐶
Double quote to prevent globbing and word splitting. SC2086
ods-ci/ods_ci/build/install_idp.sh
Line 100 in 7ef9f15
suffix_info=$(echo $idp | jq --arg pref $prefix '.suffixes[$pref]') |
📝 [shellcheck] reported by reviewdog 🐶
Double quote to prevent globbing and word splitting. SC2086
ods-ci/ods_ci/build/install_idp.sh
Line 100 in 7ef9f15
suffix_info=$(echo $idp | jq --arg pref $prefix '.suffixes[$pref]') |
📝 [shellcheck] reported by reviewdog 🐶
Double quote to prevent globbing and word splitting. SC2086
ods-ci/ods_ci/build/install_idp.sh
Line 101 in 7ef9f15
suffix_type=$(echo $suffix_info | jq --raw-output '.type') |
📝 [shellcheck] reported by reviewdog 🐶
Double quote to prevent globbing and word splitting. SC2086
ods-ci/ods_ci/build/install_idp.sh
Line 109 in 7ef9f15
rand_length=$(echo $suffix_info | jq '.rand_length') |
📝 [shellcheck] reported by reviewdog 🐶
Double quote to prevent globbing and word splitting. SC2086
ods-ci/ods_ci/build/install_idp.sh
Line 110 in 7ef9f15
generated_base_suffix=$(generate_rand_user_base_suffix $rand_length) |
📝 [shellcheck] reported by reviewdog 🐶
Double quote to prevent globbing and word splitting. SC2086
ods-ci/ods_ci/build/install_idp.sh
Line 111 in 7ef9f15
generate_incremental_suffixes $generated_base_suffix |
📝 [shellcheck] reported by reviewdog 🐶
Double quote to prevent globbing and word splitting. SC2086
ods-ci/ods_ci/build/install_idp.sh
Line 117 in 7ef9f15
rand_length=$(echo $suffix_info | jq '.rand_length') |
📝 [shellcheck] reported by reviewdog 🐶
Double quote to prevent globbing and word splitting. SC2086
ods-ci/ods_ci/build/install_idp.sh
Line 118 in 7ef9f15
generated_base_suffix=$(generate_rand_user_base_suffix $rand_length) |
📝 [shellcheck] reported by reviewdog 🐶
Double quote to prevent globbing and word splitting. SC2086
ods-ci/ods_ci/build/install_idp.sh
Line 119 in 7ef9f15
generate_custom_suffixes $generated_base_suffix |
🚫 [shellcheck] reported by reviewdog 🐶
Double quote array expansions to avoid re-splitting elements. SC2068
ods-ci/ods_ci/build/install_idp.sh
Line 131 in 7ef9f15
htp_users_string=$(printf ,%s ${HTP_USERS[@]}) |
📝 [shellcheck] reported by reviewdog 🐶
Double quote to prevent globbing and word splitting. SC2086
ods-ci/ods_ci/build/install_idp.sh
Line 132 in 7ef9f15
cluster_adm_user=$(extract_testvariables_users_mapping htpasswd cluster_admin_username $htp_users_string) |
📝 [shellcheck] reported by reviewdog 🐶
Double quote to prevent globbing and word splitting. SC2086
ods-ci/ods_ci/build/install_idp.sh
Line 135 in 7ef9f15
echo cluster admin username $cluster_adm_user |
📝 [shellcheck] reported by reviewdog 🐶
Double quote to prevent globbing and word splitting. SC2086
ods-ci/ods_ci/build/install_idp.sh
Line 141 in 7ef9f15
echo Cluster name is $CLUSTER_NAME |
📝 [shellcheck] reported by reviewdog 🐶
Double quote to prevent globbing and word splitting. SC2086
ods-ci/ods_ci/build/install_idp.sh
Line 142 in 7ef9f15
ocm create idp -c "${CLUSTER_NAME}" -t htpasswd -n htpasswd --username $cluster_adm_user --password $htp_pw |
📝 [shellcheck] reported by reviewdog 🐶
Double quote to prevent globbing and word splitting. SC2086
ods-ci/ods_ci/build/install_idp.sh
Line 142 in 7ef9f15
ocm create idp -c "${CLUSTER_NAME}" -t htpasswd -n htpasswd --username $cluster_adm_user --password $htp_pw |
📝 [shellcheck] reported by reviewdog 🐶
Double quote to prevent globbing and word splitting. SC2086
ods-ci/ods_ci/build/install_idp.sh
Line 143 in 7ef9f15
ocm create user $cluster_adm_user --cluster $CLUSTER_NAME --group=cluster-admins |
📝 [shellcheck] reported by reviewdog 🐶
Double quote to prevent globbing and word splitting. SC2086
ods-ci/ods_ci/build/install_idp.sh
Line 143 in 7ef9f15
ocm create user $cluster_adm_user --cluster $CLUSTER_NAME --group=cluster-admins |
📝 [shellcheck] reported by reviewdog 🐶
Double quote to prevent globbing and word splitting. SC2086
ods-ci/ods_ci/build/install_idp.sh
Line 145 in 7ef9f15
htp_string=$(htpasswd -b -B -n $cluster_adm_user $htp_pw) |
📝 [shellcheck] reported by reviewdog 🐶
Double quote to prevent globbing and word splitting. SC2086
ods-ci/ods_ci/build/install_idp.sh
Line 145 in 7ef9f15
htp_string=$(htpasswd -b -B -n $cluster_adm_user $htp_pw) |
📝 [shellcheck] reported by reviewdog 🐶
Double quote to prevent globbing and word splitting. SC2086
ods-ci/ods_ci/build/install_idp.sh
Line 156 in 7ef9f15
perform_oc_logic $OC_HOST $cluster_adm_user $htp_pw |
📝 [shellcheck] reported by reviewdog 🐶
Double quote to prevent globbing and word splitting. SC2086
ods-ci/ods_ci/build/install_idp.sh
Line 156 in 7ef9f15
perform_oc_logic $OC_HOST $cluster_adm_user $htp_pw |
📝 [shellcheck] reported by reviewdog 🐶
Double quote to prevent globbing and word splitting. SC2086
ods-ci/ods_ci/build/install_idp.sh
Line 156 in 7ef9f15
perform_oc_logic $OC_HOST $cluster_adm_user $htp_pw |
📝 [shellcheck] reported by reviewdog 🐶
Double quote to prevent globbing and word splitting. SC2086
ods-ci/ods_ci/build/install_idp.sh
Line 161 in 7ef9f15
oc get secret $secret_name -ojsonpath={.data.htpasswd} -n openshift-config | base64 --decode > configs/users.htpasswd |
This { is literal. Check expression (missing ;/\n?) or quote it. SC1083
ods-ci/ods_ci/build/install_idp.sh
Line 161 in 7ef9f15
oc get secret $secret_name -ojsonpath={.data.htpasswd} -n openshift-config | base64 --decode > configs/users.htpasswd |
This } is literal. Check expression (missing ;/\n?) or quote it. SC1083
ods-ci/ods_ci/build/install_idp.sh
Line 161 in 7ef9f15
oc get secret $secret_name -ojsonpath={.data.htpasswd} -n openshift-config | base64 --decode > configs/users.htpasswd |
📝 [shellcheck] reported by reviewdog 🐶
Double quote to prevent globbing and word splitting. SC2086
ods-ci/ods_ci/build/install_idp.sh
Line 166 in 7ef9f15
htpasswd -bB configs/users.htpasswd $htp_user $htp_pw |
📝 [shellcheck] reported by reviewdog 🐶
Double quote to prevent globbing and word splitting. SC2086
ods-ci/ods_ci/build/install_idp.sh
Line 166 in 7ef9f15
htpasswd -bB configs/users.htpasswd $htp_user $htp_pw |
📝 [shellcheck] reported by reviewdog 🐶
Double quote to prevent globbing and word splitting. SC2086
ods-ci/ods_ci/build/install_idp.sh
Line 171 in 7ef9f15
oc create secret generic $secret_name --from-file=htpasswd=configs/users.htpasswd --dry-run=client -o yaml -n openshift-config | oc replace -f - |
🚫 [shellcheck] reported by reviewdog 🐶
Double quote array expansions to avoid re-splitting elements. SC2068
ods-ci/ods_ci/build/install_idp.sh
Line 189 in 7ef9f15
ldap_users_str=$(printf ,%s ${LDAP_USERS[@]}) |
🚫 [shellcheck] reported by reviewdog 🐶
Double quote array expansions to avoid re-splitting elements. SC2068
ods-ci/ods_ci/build/install_idp.sh
Line 190 in 7ef9f15
ldap_pws_str=$(printf ,%s ${LDAP_PWS[@]}) |
📝 [shellcheck] reported by reviewdog 🐶
Double quote to prevent globbing and word splitting. SC2086
ods-ci/ods_ci/build/install_idp.sh
Line 194 in 7ef9f15
users_base64=$(echo -n $ldap_users_str | base64 -w 0) |
📝 [shellcheck] reported by reviewdog 🐶
Double quote to prevent globbing and word splitting. SC2086
ods-ci/ods_ci/build/install_idp.sh
Line 195 in 7ef9f15
rand_base64=$(echo -n $ldap_pws_str | base64 -w 0) |
📝 [shellcheck] reported by reviewdog 🐶
Double quote to prevent globbing and word splitting. SC2086
ods-ci/ods_ci/build/install_idp.sh
Line 203 in 7ef9f15
rand_base64=$(echo -n $rand | base64 -w 0) |
📝 [shellcheck] reported by reviewdog 🐶
Double quote to prevent globbing and word splitting. SC2086
ods-ci/ods_ci/build/install_idp.sh
Line 220 in 7ef9f15
ocm post /api/clusters_mgmt/v1/clusters/${ocm_clusterid}/identity_providers --body=configs/create_ldap_idp.jinja |
📝 [shellcheck] reported by reviewdog 🐶
Double quote to prevent globbing and word splitting. SC2086
ods-ci/ods_ci/build/install_idp.sh
Line 227 in 7ef9f15
test_user=$(extract_testvariables_users_mapping ldap TEST_USER $ldap_users_str) |
📝 [shellcheck] reported by reviewdog 🐶
Double quote to prevent globbing and word splitting. SC2086
ods-ci/ods_ci/build/install_idp.sh
Line 228 in 7ef9f15
test_user_2=$(extract_testvariables_users_mapping ldap TEST_USER_2 $ldap_users_str) |
📝 [shellcheck] reported by reviewdog 🐶
Double quote to prevent globbing and word splitting. SC2086
ods-ci/ods_ci/build/install_idp.sh
Line 229 in 7ef9f15
test_user_3=$(extract_testvariables_users_mapping ldap TEST_USER_3 $ldap_users_str) |
📝 [shellcheck] reported by reviewdog 🐶
Double quote to prevent globbing and word splitting. SC2086
ods-ci/ods_ci/build/install_idp.sh
Line 230 in 7ef9f15
test_user_4=$(extract_testvariables_users_mapping ldap TEST_USER_4 $ldap_users_str) |
📝 [shellcheck] reported by reviewdog 🐶
Double quote to prevent globbing and word splitting. SC2086
ods-ci/ods_ci/build/install_idp.sh
Line 257 in 7ef9f15
groups=$(jq -r --arg idpname ldap --arg pref $prefix '.[][$idpname].groups_map[$pref][]' configs/templates/user_config.json) |
📝 [shellcheck] reported by reviewdog 🐶
Double quote to prevent globbing and word splitting. SC2086
ods-ci/ods_ci/build/install_idp.sh
Line 258 in 7ef9f15
echo $groups |
Quote to prevent word splitting/globbing, or split robustly with mapfile or read -a. SC2206
ods-ci/ods_ci/build/install_idp.sh
Line 259 in 7ef9f15
groups=($groups) |
📝 [shellcheck] reported by reviewdog 🐶
Double quote to prevent globbing and word splitting. SC2086
ods-ci/ods_ci/build/install_idp.sh
Line 264 in 7ef9f15
add_users_to_ocm_dedicated_admins $prefix |
📝 [shellcheck] reported by reviewdog 🐶
Double quote to prevent globbing and word splitting. SC2086
ods-ci/ods_ci/build/install_idp.sh
Line 268 in 7ef9f15
add_users_to_groups $group $prefix |
📝 [shellcheck] reported by reviewdog 🐶
Double quote to prevent globbing and word splitting. SC2086
ods-ci/ods_ci/build/install_idp.sh
Line 268 in 7ef9f15
add_users_to_groups $group $prefix |
📝 [shellcheck] reported by reviewdog 🐶
Double quote to prevent globbing and word splitting. SC2086
ods-ci/ods_ci/build/install_idp.sh
Line 276 in 7ef9f15
oc adm groups add-users $1 $user |
📝 [shellcheck] reported by reviewdog 🐶
Double quote to prevent globbing and word splitting. SC2086
ods-ci/ods_ci/build/install_idp.sh
Line 276 in 7ef9f15
oc adm groups add-users $1 $user |
📝 [shellcheck] reported by reviewdog 🐶
Double quote to prevent globbing and word splitting. SC2086
ods-ci/ods_ci/build/install_idp.sh
Line 284 in 7ef9f15
ocm create user $user --cluster $CLUSTER_NAME --group=dedicated-admins |
📝 [shellcheck] reported by reviewdog 🐶
Double quote to prevent globbing and word splitting. SC2086
ods-ci/ods_ci/build/install_idp.sh
Line 284 in 7ef9f15
ocm create user $user --cluster $CLUSTER_NAME --group=dedicated-admins |
📝 [shellcheck] reported by reviewdog 🐶
Double quote to prevent globbing and word splitting. SC2086
ods-ci/ods_ci/build/install_idp.sh
Line 309 in 7ef9f15
echo OCM cluster ID: $ocm_clusterid |
📝 [shellcheck] reported by reviewdog 🐶
Double quote to prevent globbing and word splitting. SC2086
ods-ci/ods_ci/build/install_idp.sh
Line 320 in 7ef9f15
done < <(ocm get /api/clusters_mgmt/v1/clusters/$ocm_clusterid/identity_providers) |
📝 [shellcheck] reported by reviewdog 🐶
Double quote to prevent globbing and word splitting. SC2086
ods-ci/ods_ci/build/install_idp.sh
Line 338 in 7ef9f15
idp=$(jq --arg idpname $1 '.[][$idpname]' configs/templates/user_config.json) |
📝 [shellcheck] reported by reviewdog 🐶
Double quote to prevent globbing and word splitting. SC2086
ods-ci/ods_ci/build/install_idp.sh
Line 339 in 7ef9f15
pw=$(echo $idp | jq -r '.pw') |
📝 [shellcheck] reported by reviewdog 🐶
Double quote to prevent globbing and word splitting. SC2086
ods-ci/ods_ci/build/install_idp.sh
Line 345 in 7ef9f15
test_user=$(echo $idp | jq -r '.TEST_USER') |
test is referenced but not assigned (for output from commands, use "$(test ...)" ). SC2154
ods-ci/ods_ci/build/install_idp.sh
Line 346 in 7ef9f15
echo $test |
📝 [shellcheck] reported by reviewdog 🐶
Double quote to prevent globbing and word splitting. SC2086
ods-ci/ods_ci/build/install_idp.sh
Line 346 in 7ef9f15
echo $test |
📝 [shellcheck] reported by reviewdog 🐶
Double quote to prevent globbing and word splitting. SC2086
ods-ci/ods_ci/build/install_idp.sh
Line 347 in 7ef9f15
test_user_2=$(echo $idp | jq -r '.TEST_USER_2') |
📝 [shellcheck] reported by reviewdog 🐶
Double quote to prevent globbing and word splitting. SC2086
ods-ci/ods_ci/build/install_idp.sh
Line 348 in 7ef9f15
test_user_3=$(echo $idp | jq -r '.TEST_USER_3') |
📝 [shellcheck] reported by reviewdog 🐶
Double quote to prevent globbing and word splitting. SC2086
ods-ci/ods_ci/build/install_idp.sh
Line 349 in 7ef9f15
test_user_4=$(echo $idp | jq -r '.TEST_USER_4') |
📝 [shellcheck] reported by reviewdog 🐶
Double quote to prevent globbing and word splitting. SC2086
ods-ci/ods_ci/build/install_idp.sh
Line 360 in 7ef9f15
cluster_admin_user=$(echo $idp | jq -r '.cluster_admin_username') |
Variable was used as an array but is now assigned a string. SC2178
ods-ci/ods_ci/build/install_idp.sh
Line 366 in 7ef9f15
prefixes=$(echo $idp | jq --raw-output '.prefixes[]') |
📝 [shellcheck] reported by reviewdog 🐶
Double quote to prevent globbing and word splitting. SC2086
ods-ci/ods_ci/build/install_idp.sh
Line 366 in 7ef9f15
prefixes=$(echo $idp | jq --raw-output '.prefixes[]') |
Expanding an array without an index only gives the first element. SC2128
ods-ci/ods_ci/build/install_idp.sh
Line 367 in 7ef9f15
prefixes=($prefixes) |
Quote to prevent word splitting/globbing, or split robustly with mapfile or read -a. SC2206
ods-ci/ods_ci/build/install_idp.sh
Line 367 in 7ef9f15
prefixes=($prefixes) |
Expanding an array without an index only gives the first element. SC2128
ods-ci/ods_ci/build/install_idp.sh
Line 368 in 7ef9f15
if [[ $prefixes = "null" || -z "${prefixes// }" || ! ${#prefixes[@]} -gt 0 ]]; then |
📝 [shellcheck] reported by reviewdog 🐶
Double quote to prevent globbing and word splitting. SC2086
ods-ci/ods_ci/build/install_idp.sh
Line 373 in 7ef9f15
suffix_info=$(echo $idp | jq --arg pref $prefix '.suffixes[$pref]') |
📝 [shellcheck] reported by reviewdog 🐶
Double quote to prevent globbing and word splitting. SC2086
ods-ci/ods_ci/build/install_idp.sh
Line 373 in 7ef9f15
suffix_info=$(echo $idp | jq --arg pref $prefix '.suffixes[$pref]') |
📝 [shellcheck] reported by reviewdog 🐶
Double quote to prevent globbing and word splitting. SC2086
ods-ci/ods_ci/build/install_idp.sh
Line 374 in 7ef9f15
suffix_type=$(echo $suffix_info | jq --raw-output '.type') |
[shellcheck] reported by reviewdog 🐶
Use -z instead of ! -n. SC2236
ods-ci/ods_ci/build/install_idp.sh
Line 375 in 7ef9f15
if [[ $suffix_info = "null" || -z "${suffix_info// }" || ! -n $suffix_info || $suffix_type = "null" || -z "${suffix_type// }" || ! -n $suffix_type ]]; then |
[shellcheck] reported by reviewdog 🐶
Use -z instead of ! -n. SC2236
ods-ci/ods_ci/build/install_idp.sh
Line 375 in 7ef9f15
if [[ $suffix_info = "null" || -z "${suffix_info// }" || ! -n $suffix_info || $suffix_type = "null" || -z "${suffix_type// }" || ! -n $suffix_type ]]; then |
📝 [shellcheck] reported by reviewdog 🐶
Double quote to prevent globbing and word splitting. SC2086
ods-ci/ods_ci/build/install_idp.sh
Line 383 in 7ef9f15
n_users=$(echo $suffix_info | jq '.n_users') |
📝 [shellcheck] reported by reviewdog 🐶
Double quote to prevent globbing and word splitting. SC2086
ods-ci/ods_ci/build/install_idp.sh
Line 390 in 7ef9f15
n_users=$(echo $suffix_info | jq '.n_users') |
📝 [shellcheck] reported by reviewdog 🐶
Double quote to prevent globbing and word splitting. SC2086
ods-ci/ods_ci/build/install_idp.sh
Line 391 in 7ef9f15
rand_length=$(echo $suffix_info | jq '.rand_length') |
📝 [shellcheck] reported by reviewdog 🐶
Double quote to prevent globbing and word splitting. SC2086
ods-ci/ods_ci/build/install_idp.sh
Line 402 in 7ef9f15
list=$(echo $suffix_info | jq -c '.list[]') |
Quote to prevent word splitting/globbing, or split robustly with mapfile or read -a. SC2206
ods-ci/ods_ci/build/install_idp.sh
Line 403 in 7ef9f15
list=($list) |
Expanding an array without an index only gives the first element. SC2128
ods-ci/ods_ci/build/install_idp.sh
Line 404 in 7ef9f15
if [[ $list = "null" || -z "${list// }" || ! ${#list[@]} -gt 0 ]]; then |
📝 [shellcheck] reported by reviewdog 🐶
Double quote to prevent globbing and word splitting. SC2086
ods-ci/ods_ci/build/install_idp.sh
Line 411 in 7ef9f15
rand_length=$(echo $suffix_info | jq '.rand_length') |
📝 [shellcheck] reported by reviewdog 🐶
Double quote to prevent globbing and word splitting. SC2086
ods-ci/ods_ci/build/install_idp.sh
Line 416 in 7ef9f15
list=$(echo $suffix_info | jq -c '.list[]') |
Quote to prevent word splitting/globbing, or split robustly with mapfile or read -a. SC2206
ods-ci/ods_ci/build/install_idp.sh
Line 417 in 7ef9f15
list=($list) |
Expanding an array without an index only gives the first element. SC2128
ods-ci/ods_ci/build/install_idp.sh
Line 418 in 7ef9f15
if [[ $list = "null" || -z "${list// }" || ! ${#list[@]} -gt 0 ]]; then |
Variable was used as an array but is now assigned a string. SC2178
ods-ci/ods_ci/build/install_idp.sh
Line 427 in 7ef9f15
groups=$(jq -r --arg idpname ldap --arg pref $prefix '.[][$idpname].groups_map[$pref][]' configs/templates/user_config.json) |
📝 [shellcheck] reported by reviewdog 🐶
Double quote to prevent globbing and word splitting. SC2086
ods-ci/ods_ci/build/install_idp.sh
Line 427 in 7ef9f15
groups=$(jq -r --arg idpname ldap --arg pref $prefix '.[][$idpname].groups_map[$pref][]' configs/templates/user_config.json) |
Expanding an array without an index only gives the first element. SC2128
ods-ci/ods_ci/build/install_idp.sh
Line 428 in 7ef9f15
groups=($groups) |
Quote to prevent word splitting/globbing, or split robustly with mapfile or read -a. SC2206
ods-ci/ods_ci/build/install_idp.sh
Line 428 in 7ef9f15
groups=($groups) |
Expanding an array without an index only gives the first element. SC2128
ods-ci/ods_ci/build/install_idp.sh
Line 429 in 7ef9f15
if [[ $groups = "null" || -z "${groups// }" || ! ${#groups[@]} -gt 0 ]]; then |
TEST_VARIABLES_FILE="test-variables.yml" | ||
|
||
AWS_SHARED_CREDENTIALS_FILE="${CLUSTER_PROFILE_DIR}/.awscred" | ||
AWS_ACCESS_KEY_ID=$(cat $AWS_SHARED_CREDENTIALS_FILE | grep aws_access_key_id | tr -d ' ' | cut -d '=' -f 2) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TEST_VARIABLES_FILE="test-variables.yml" | ||
|
||
AWS_SHARED_CREDENTIALS_FILE="${CLUSTER_PROFILE_DIR}/.awscred" | ||
AWS_ACCESS_KEY_ID=$(cat $AWS_SHARED_CREDENTIALS_FILE | grep aws_access_key_id | tr -d ' ' | cut -d '=' -f 2) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
||
AWS_SHARED_CREDENTIALS_FILE="${CLUSTER_PROFILE_DIR}/.awscred" | ||
AWS_ACCESS_KEY_ID=$(cat $AWS_SHARED_CREDENTIALS_FILE | grep aws_access_key_id | tr -d ' ' | cut -d '=' -f 2) | ||
AWS_SECRET_ACCESS_KEY=$(cat $AWS_SHARED_CREDENTIALS_FILE | grep aws_secret_access_key | tr -d ' ' | cut -d '=' -f 2) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
||
AWS_SHARED_CREDENTIALS_FILE="${CLUSTER_PROFILE_DIR}/.awscred" | ||
AWS_ACCESS_KEY_ID=$(cat $AWS_SHARED_CREDENTIALS_FILE | grep aws_access_key_id | tr -d ' ' | cut -d '=' -f 2) | ||
AWS_SECRET_ACCESS_KEY=$(cat $AWS_SHARED_CREDENTIALS_FILE | grep aws_secret_access_key | tr -d ' ' | cut -d '=' -f 2) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
echo "Performing oc login using TEST username and password" | ||
username=$(yq eval '.TEST_USER.USERNAME' test-variables.yml) | ||
password=$(yq eval '.TEST_USER.PASSWORD' test-variables.yml) | ||
oc login "$OC_HOST" --username $username --password $password --insecure-skip-tls-verify=true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
echo "Performing oc login using TEST username and password" | ||
username=$(yq eval '.TEST_USER.USERNAME' test-variables.yml) | ||
password=$(yq eval '.TEST_USER.PASSWORD' test-variables.yml) | ||
oc login "$OC_HOST" --username $username --password $password --insecure-skip-tls-verify=true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📝 [shellcheck] reported by reviewdog 🐶
Double quote to prevent globbing and word splitting. SC2086
ods-ci/ods_ci/build/install_idp.sh
Line 6 in 7ef9f15
oc login $1 --username $2 --password $3 || (echo "Login failed $i times. Trying again in 30 seconds (max 7 times)." && sleep 30) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📝 [shellcheck] reported by reviewdog 🐶
Double quote to prevent globbing and word splitting. SC2086
ods-ci/ods_ci/build/install_idp.sh
Line 6 in 7ef9f15
oc login $1 --username $2 --password $3 || (echo "Login failed $i times. Trying again in 30 seconds (max 7 times)." && sleep 30) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📝 [shellcheck] reported by reviewdog 🐶
Double quote to prevent globbing and word splitting. SC2086
ods-ci/ods_ci/build/install_idp.sh
Line 6 in 7ef9f15
oc login $1 --username $2 --password $3 || (echo "Login failed $i times. Trying again in 30 seconds (max 7 times)." && sleep 30) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📝 [shellcheck] reported by reviewdog 🐶
Double quote to prevent globbing and word splitting. SC2086
ods-ci/ods_ci/build/install_idp.sh
Line 16 in 7ef9f15
ocm login --token=${OCM_TOKEN} --url=${OCM_ENV} ;\ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📝 [shellcheck] reported by reviewdog 🐶
Double quote to prevent globbing and word splitting. SC2086
ods-ci/ods_ci/build/install_idp.sh
Line 16 in 7ef9f15
ocm login --token=${OCM_TOKEN} --url=${OCM_ENV} ;\ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📝 [shellcheck] reported by reviewdog 🐶
Double quote to prevent globbing and word splitting. SC2086
ods-ci/ods_ci/build/install_idp.sh
Line 18 in 7ef9f15
ocm login --token=${OCM_TOKEN} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[shellcheck] reported by reviewdog 🐶
Useless cat. Consider 'cmd < file | ..' or 'cmd file | ..' instead. SC2002
ods-ci/ods_ci/build/install_idp.sh
Line 28 in 7ef9f15
cat /dev/urandom | tr -dc "0-9a-zA-Z@#$%_+=" | head -c "${length}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[shellcheck] reported by reviewdog 🐶
ods-ci/ods_ci/build/install_idp.sh
Line 35 in 7ef9f15
array[$RANDOM]=$i |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [shellcheck] reported by reviewdog 🐶
Double quote array expansions to avoid re-splitting elements. SC2068
ods-ci/ods_ci/build/install_idp.sh
Line 37 in 7ef9f15
printf %s ${array[@]::$1} $'\n' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📝 [shellcheck] reported by reviewdog 🐶
Double quote to prevent globbing and word splitting. SC2086
ods-ci/ods_ci/build/install_idp.sh
Line 41 in 7ef9f15
n_users=$(echo $suffix_info | jq '.n_users') |
Quality Gate passedIssues Measures |
Outdated. |
No description provided.