-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[model server] Backport pre and post upgrade tests #2137
[model server] Backport pre and post upgrade tests #2137
Conversation
rh-pre-commit.version: 2.3.2 rh-pre-commit.check-secrets: ENABLED
Quality Gate passedIssues Measures |
@@ -264,6 +264,7 @@ | |||
... set to ${TRUE}. | |||
[Arguments] ${model_name} ${inference_input} ${token_auth}=${FALSE} ${project_title}=${NONE} | |||
... ${kserve_mode}=Serverless ${deployment_mode}=UI ${service_port}=8888 ${end_point}=${NONE} | |||
... ${service_account_name}=default-name ${token}=${NONE} ${set_json_content_type}=${FALSE} |
Check warning
Code scanning / Robocop
Keyword argument '{{ name }}' is not used Warning test
@@ -275,18 +276,24 @@ | |||
IF "${project_title}" == "${NONE}" | |||
${project_title}= Get Model Project ${model_name} | |||
END | |||
${token}= Get Access Token via UI ${project_title} | |||
IF $token == ${NONE} | |||
${token}= Get Access Token via UI ${project_title} service_account_name=${service_account_name} |
Check warning
Code scanning / Robocop
Keyword name '{{ keyword_name }}' does not follow case convention Warning test
Robot Results
|
Wait For RHODS Dashboard To Load | ||
... wait_for_cards=${FALSE} | ||
... expected_page=Data Science Projects | ||
Create Data Science Project title=${PRJ_TITLE} description=${PRJ_DESCRIPTION} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @rnetser please consider following one approach for specifying arguments - one line vs multi-line definition.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@apodhrad as this is backport and we do not have that approach in newer branches i think we should not do it in this pr (because if we will need to backport more changes than this will cause conflicts).
bf16357
into
red-hat-data-services:releases/2.13.0
rh-pre-commit.version: 2.3.2
rh-pre-commit.check-secrets: ENABLED
verified