Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[model server] Backport pre and post upgrade tests #2137

Merged

Conversation

rnetser
Copy link
Contributor

@rnetser rnetser commented Dec 16, 2024

rh-pre-commit.version: 2.3.2
rh-pre-commit.check-secrets: ENABLED

verified

Installing the current project: ods-ci (0.1.0)
==============================================================================
Tests
==============================================================================
Tests.Rhoai Upgrade
==============================================================================
2024-12-16 18:12:34,680 - RPA.core.certificates - INFO - Truststore not in use, HTTPS traffic validated against `certifi` package. (requires Python 3.10.12 and 'pip' 23.2.1 at minimum)
Tests.Rhoai Upgrade.Pre Upgrade :: Test Suite for Upgrade testing, to be ru...
==============================================================================
[ WARN ] No Prometheus namespace found
[ WARN ] No Prometheus namespace found
Verify Model Can Be Deployed Via UI For Upgrade :: Verify Model Ca... ...No Models Deployed, Skipping Cleanup
Verify Model Can Be Deployed Via UI For Upgrade :: Verify Model Ca... | PASS |
------------------------------------------------------------------------------
Tests.Rhoai Upgrade.Pre Upgrade :: Test Suite for Upgrade testing,... | PASS |
1 test, 1 passed, 0 failed
==============================================================================
Tests.Rhoai Upgrade.Post Upgrade :: Test Suite for Upgrade testing,to be ru...
==============================================================================
[ WARN ] No Prometheus namespace found
DataScienceCluster default-dsc in the namespace redhat-ods-operator attribute .status.release.name value is OpenShift AI Self-Managed
DSCInitialization default-dsci in the namespace redhat-ods-operator attribute .status.release.name value is EMPTY
DataScienceCluster default-dsc in the namespace redhat-ods-operator attribute .status.release.version value is 2.13.1
DSCInitialization default-dsci in the namespace redhat-ods-operator attribute .status.release.version value is 0.0.0
[ WARN ] No Prometheus namespace found
Test Inference Post RHODS Upgrade :: Test the inference result aft... | PASS |
------------------------------------------------------------------------------
Tests.Rhoai Upgrade.Post Upgrade :: Test Suite for Upgrade testing... | PASS |
1 test, 1 passed, 0 failed
==============================================================================
Tests.Rhoai Upgrade                                                   | PASS |
2 tests, 2 passed, 0 failed
==============================================================================
Tests                                                                 | PASS |
2 tests, 2 passed, 0 failed
==============================================================================

rh-pre-commit.version: 2.3.2
rh-pre-commit.check-secrets: ENABLED
@@ -264,6 +264,7 @@
... set to ${TRUE}.
[Arguments] ${model_name} ${inference_input} ${token_auth}=${FALSE} ${project_title}=${NONE}
... ${kserve_mode}=Serverless ${deployment_mode}=UI ${service_port}=8888 ${end_point}=${NONE}
... ${service_account_name}=default-name ${token}=${NONE} ${set_json_content_type}=${FALSE}

Check warning

Code scanning / Robocop

Keyword argument '{{ name }}' is not used Warning test

Keyword argument '${set_json_content_type}' is not used
@@ -275,18 +276,24 @@
IF "${project_title}" == "${NONE}"
${project_title}= Get Model Project ${model_name}
END
${token}= Get Access Token via UI ${project_title}
IF $token == ${NONE}
${token}= Get Access Token via UI ${project_title} service_account_name=${service_account_name}

Check warning

Code scanning / Robocop

Keyword name '{{ keyword_name }}' does not follow case convention Warning test

Keyword name 'Get Access Token via UI' does not follow case convention
Copy link
Contributor

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass %
536 0 0 536 100

@rnetser rnetser requested a review from mwaykole December 16, 2024 17:46
Wait For RHODS Dashboard To Load
... wait_for_cards=${FALSE}
... expected_page=Data Science Projects
Create Data Science Project title=${PRJ_TITLE} description=${PRJ_DESCRIPTION}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @rnetser please consider following one approach for specifying arguments - one line vs multi-line definition.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@apodhrad as this is backport and we do not have that approach in newer branches i think we should not do it in this pr (because if we will need to backport more changes than this will cause conflicts).

@rnetser rnetser merged commit bf16357 into red-hat-data-services:releases/2.13.0 Dec 17, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants