-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test to Put non ascii characters in a S3 request #567
Conversation
Signed-off-by: Tejas Chandramouli <[email protected]>
bucket_name = utils.gen_bucket_name_from_userid(user_name, rand_no=bc) | ||
aws_reusable.create_bucket(bucket_name, endpoint) | ||
log.info(f"Bucket {bucket_name} created") | ||
object_name = "ˍ´--øÆ.txt" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @TejasC88 , IMO instead of making new script file,shall we make use of existing script file:
https://github.com/red-hat-storage/ceph-qe-scripts/blob/master/rgw/v2/tests/aws/test_aws.py#L73
post line 73 please include condition:
i.e: if config.test_ops.get("non_ascii_character_upload", False):
and place below snipet:
object_name = "ˍ´--øÆ.txt
utils.exec_shell_cmd(f"fallocate -l 1K {object_name}")
aws_reusable.put_object(bucket_name, object_name, endpoint)
log.info(
"Object name and body containing non ascii character upload succeeded" )
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ckulal Done , pls review
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated pass log: http://magna002.ceph.redhat.com/ceph-qe-logs/tejas/non_ascii.txt
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
Signed-off-by: Tejas Chandramouli <[email protected]>
@mkasturi18 Added the code to do a get object of the non-ascii S3 object , pls review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changes looks good
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: hmaheswa, mkasturi18, TejasC88 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Based on Polarion ID : CEPH-83572765
We test non ascii characters in the body of a S3 Put Request, there should be no errors from RGW.
Pass log : http://magna002.ceph.redhat.com/ceph-qe-logs/tejas/non_ascii.txt