Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test to Put non ascii characters in a S3 request #567

Merged
merged 2 commits into from
Mar 12, 2024

Conversation

TejasC88
Copy link
Contributor

@TejasC88 TejasC88 commented Mar 7, 2024

Based on Polarion ID : CEPH-83572765
We test non ascii characters in the body of a S3 Put Request, there should be no errors from RGW.

Pass log : http://magna002.ceph.redhat.com/ceph-qe-logs/tejas/non_ascii.txt

@TejasC88 TejasC88 added the RGW RGW label Mar 7, 2024
@TejasC88 TejasC88 requested a review from a team March 7, 2024 12:41
bucket_name = utils.gen_bucket_name_from_userid(user_name, rand_no=bc)
aws_reusable.create_bucket(bucket_name, endpoint)
log.info(f"Bucket {bucket_name} created")
object_name = "ˍ´--øÆ.txt"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @TejasC88 , IMO instead of making new script file,shall we make use of existing script file:
https://github.com/red-hat-storage/ceph-qe-scripts/blob/master/rgw/v2/tests/aws/test_aws.py#L73
post line 73 please include condition:

i.e: if config.test_ops.get("non_ascii_character_upload", False):

and place below snipet:
object_name = "ˍ´--øÆ.txt
utils.exec_shell_cmd(f"fallocate -l 1K {object_name}")
aws_reusable.put_object(bucket_name, object_name, endpoint)
log.info(
"Object name and body containing non ascii character upload succeeded" )

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ckulal Done , pls review

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

@ckulal ckulal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

anrao19
anrao19 previously approved these changes Mar 8, 2024
@openshift-ci openshift-ci bot added the lgtm Looks good to me label Mar 8, 2024
hmaheswa
hmaheswa previously approved these changes Mar 11, 2024
@TejasC88 TejasC88 dismissed stale reviews from hmaheswa and anrao19 via ae3548e March 11, 2024 11:27
@openshift-ci openshift-ci bot removed the lgtm Looks good to me label Mar 11, 2024
@TejasC88 TejasC88 added the DNM label Mar 11, 2024
Signed-off-by: Tejas Chandramouli <[email protected]>
@TejasC88
Copy link
Contributor Author

@mkasturi18 Added the code to do a get object of the non-ascii S3 object , pls review
Updated Pass log : http://magna002.ceph.redhat.com/ceph-qe-logs/tejas/non_ascii.txt

@TejasC88 TejasC88 removed the DNM label Mar 11, 2024
@openshift-ci openshift-ci bot added the lgtm Looks good to me label Mar 12, 2024
Copy link
Contributor

@mkasturi18 mkasturi18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes looks good

Copy link
Contributor

openshift-ci bot commented Mar 12, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: hmaheswa, mkasturi18, TejasC88

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify bot merged commit 768832e into red-hat-storage:master Mar 12, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Looks good to me RGW RGW
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants