Check for transition of Encrypted and Compressed objects #611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viduship
previously approved these changes
Jul 8, 2024
anrao19
reviewed
Jul 11, 2024
rgw/v2/tests/s3_swift/configs/test_cloud_transition_headobject_false.yaml
Show resolved
Hide resolved
anrao19
reviewed
Jul 11, 2024
anrao19
reviewed
Jul 11, 2024
| @@ -56,6 +59,20 @@ def test_exec(config, ssh_con): | |||
| ) | |||
| log.info("creating bucket with name: %s" % bucket_name_to_create) | |||
There was a problem hiding this comment.
can we include format string instead of %s
anrao19
reviewed
Jul 11, 2024
| # get bucket encryption | ||
| log.info(f"get bucket encryption for bucket : {bucket_name_to_create}") | ||
| sse_s3.get_bucket_encryption(s3_client1, bucket_name_to_create) | ||
|
|
||
| if config.test_ops["create_object"] is True: | ||
| # uploading data | ||
| log.info("s3 objects to create: %s" % config.objects_count) |
There was a problem hiding this comment.
same here about format string
anrao19
reviewed
Jul 11, 2024
| @@ -1,4 +1,4 @@ | |||
| # script: test_cloud_transitions.py | |||
| # script:test_cloud_transitions.py | |||
There was a problem hiding this comment.
update name as script: test_cloud_transition.py.
we do not have script with name : test_cloud_transitions.py
Signed-off-by: Tejas Chandramouli <[email protected]>
ckulal
approved these changes
Jul 18, 2024
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: anrao19, ckulal, TejasC88 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Polarion : CEPH-83575497
Cloud transition of compressed and encrypted objects to AWS.
We have a known issue with this test https://bugzilla.redhat.com/show_bug.cgi?id=2294512
Fail log : http://magna002.ceph.redhat.com/cephci-jenkins/tchandra/cloud_transition_encrypt.txt