Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test the CORS feature #638

Closed
wants to merge 1 commit into from
Closed

Test the CORS feature #638

wants to merge 1 commit into from

Conversation

TejasC88
Copy link
Contributor

@TejasC88 TejasC88 commented Oct 18, 2024 •
edited
Loading

Polarion ID : CEPH-10355

Test CORS using cURL GET,PUT and DELETE api's
Pass log : http://magna002.ceph.redhat.com/cephci-jenkins/tchandra/CORS.txt

@TejasC88 TejasC88 requested a review from a team October 18, 2024 12:15
@TejasC88
Test the CORS feature
f1a75f8 
Signed-off-by: Tejas Chandramouli <[email protected]>
@TejasC88 TejasC88 requested review from anrao19 and a team October 28, 2024 07:49
viduship
viduship reviewed Oct 28, 2024
View reviewed changes
rgw/v2/tests/curl/test_cors_using_curl.py
test_cors_using_curl.yaml

Operation:
Test CORS on a bucket using CURL API calls.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TejasC88 Request to make the operation more descriptive step by step would be better

anrao19
anrao19 approved these changes Oct 28, 2024
View reviewed changes
Copy link
Contributor

@anrao19 anrao19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openshift-ci openshift-ci bot added the lgtm Looks good to me label Oct 28, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Oct 28, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: anrao19, TejasC88

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 28, 2024

"This pull request now has conflicts with the target branch. Could you please resolve conflicts and force push the corrected changes?"

hmaheswa
hmaheswa reviewed Oct 28, 2024
View reviewed changes
rgw/v2/tests/curl/configs/test_cors_using_curl.yaml
config:
user_count: 1
bucket_count: 1
objects_count: 1
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TejasC88
could you please increase objects count to something like 25

@ckulal
Copy link
Contributor

ckulal commented Oct 28, 2024

please resolve merge conflict.

@openshift-merge-robot
Copy link

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@TejasC88 TejasC88 closed this Nov 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hmaheswa hmaheswa hmaheswa left review comments

@viduship viduship viduship left review comments

@anrao19 anrao19 anrao19 approved these changes

Assignees

@anrao19 anrao19

Labels
lgtm Looks good to me needs-rebase RGW RGW Tier-2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@TejasC88 @ckulal @openshift-merge-robot @viduship @anrao19 @hmaheswa