Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wait for the ceph command to execute successfully in the rolling nodes terminate and rolling nodes restart tests #10915

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Wait for the ceph command to execute successfully in the rolling nodes terminate and rolling nodes restart tests #10915

wants to merge 3 commits into from
+71 −2

Conversation

yitzhak12
Copy link
Contributor

@yitzhak12 yitzhak12 requested review from a team as code owners November 24, 2024 15:52
@pull-request-size pull-request-size bot added the size/M PR that changes 30-99 lines label Nov 24, 2024
ocs-ci
ocs-ci reviewed Nov 24, 2024
View reviewed changes
Copy link

@ocs-ci ocs-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unknown PR validation on existing cluster

Cluster Name: ikave-aws418
Cluster Configuration:
PR Test Suite: tier4b
PR Test Path: tests/functional/z_cluster/nodes/test_nodes_restart.py::TestNodesRestart::test_rolling_nodes_restart
Additional Test Params:
OCP VERSION: 4.18
OCS VERSION: 4.18
tested against branch: master

Job state: ABORTED.

Modify the function 'wait_for_ceph_cmd_execute_successfully', wait fo…
b01beed 
…r the ceph command to execute successfully after rolling nodes terminate and rolling nodes restart tests

Signed-off-by: Itzhak Kave <[email protected]>
@yitzhak12 yitzhak12 force-pushed the restart-tool-pod-after-node-destructive-tests branch from f24a29d to b01beed Compare November 25, 2024 11:54
ocs-ci
ocs-ci reviewed Nov 25, 2024
View reviewed changes
Copy link

@ocs-ci ocs-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR validation on existing cluster

Cluster Name: ikave-aws418
Cluster Configuration:
PR Test Suite: tier4b
PR Test Path: tests/functional/z_cluster/nodes/test_nodes_restart.py::TestNodesRestart::test_rolling_nodes_restart
Additional Test Params:
OCP VERSION: 4.18
OCS VERSION: 4.18
tested against branch: master

Job PASSED.

@yitzhak12 yitzhak12 force-pushed the restart-tool-pod-after-node-destructive-tests branch from 38a243e to 2f2ce3d Compare November 25, 2024 12:41
ocs-ci
ocs-ci reviewed Nov 25, 2024
View reviewed changes
Copy link

@ocs-ci ocs-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR validation on existing cluster

Cluster Name: ikave-aws418
Cluster Configuration:
PR Test Suite: tier4b
PR Test Path: tests/functional/z_cluster/nodes/test_nodes_restart.py::TestNodesRestart::test_rolling_nodes_restart
Additional Test Params:
OCP VERSION: 4.18
OCS VERSION: 4.18
tested against branch: master

Job PASSED.

ocs-ci
ocs-ci reviewed Nov 25, 2024
View reviewed changes
Copy link

@ocs-ci ocs-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR validation on existing cluster

Cluster Name: ikave-aws418
Cluster Configuration:
PR Test Suite: tier4b
PR Test Path: tests/functional/z_cluster/nodes/test_rolling_terminate_and_recovery.py
Additional Test Params:
OCP VERSION: 4.18
OCS VERSION: 4.18
tested against branch: master

Job FAILED (installation failed, tests not executed).

ocs-ci
ocs-ci reviewed Nov 25, 2024
View reviewed changes
Copy link

@ocs-ci ocs-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR validation on existing cluster

Cluster Name: ikave-aws418
Cluster Configuration:
PR Test Suite: tier4b
PR Test Path: tests/functional/z_cluster/nodes/test_rolling_terminate_and_recovery.py
Additional Test Params:
OCP VERSION: 4.18
OCS VERSION: 4.18
tested against branch: master

Job PASSED.

@yitzhak12 yitzhak12 added the Verified Mark when PR was verified and log provided label Nov 25, 2024
amr1ta
amr1ta previously approved these changes Nov 26, 2024
View reviewed changes
Copy link
Contributor

@amr1ta amr1ta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good

@openshift-ci openshift-ci bot added the lgtm label Nov 26, 2024
ebenahar
ebenahar reviewed Nov 26, 2024
View reviewed changes
ocs_ci/ocs/resources/pod.py Outdated
@@ -3955,3 +3956,66 @@ def get_prometheus_pods(
pods_with_label_match = get_pods_having_label(prometheus_label, namespace)
prometheus_pod_objs = [Pod(**prometheus) for prometheus in pods_with_label_match]
return prometheus_pod_objs


def get_ceph_tool_pods(ceph_tool_label=constants.TOOL_APP_LABEL, namespace=None):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

similar function already exists - https://github.com/red-hat-storage/ocs-ci/blob/master/ocs_ci/ocs/resources/pod.py#L760

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I will change the name prefix. The problem with the function you mentioned is that it performs extra conditions and does not just get all the ceph tool pods.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not fixing/adjusting the existing function? Having 2 functions for similar purpose isn't ideal

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can do that. The problem is that we must be more careful as this function is widely used in our tests.

@openshift-ci openshift-ci bot removed the lgtm label Nov 26, 2024
@openshift-ci openshift-ci bot added the lgtm label Nov 26, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Nov 26, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: AviadP, yitzhak12

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

ocs-ci
ocs-ci reviewed Nov 26, 2024
View reviewed changes
Copy link

@ocs-ci ocs-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR validation on existing cluster

Cluster Name: ikave-aws418
Cluster Configuration:
PR Test Suite: tier4b
PR Test Path: tests/functional/z_cluster/nodes/test_nodes_restart.py::TestNodesRestart::test_rolling_nodes_restart
Additional Test Params:
OCP VERSION: 4.18
OCS VERSION: 4.18
tested against branch: master

Job PASSED.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ocs-ci ocs-ci ocs-ci left review comments

@ebenahar ebenahar ebenahar left review comments

@AviadP AviadP AviadP approved these changes

@amr1ta amr1ta amr1ta left review comments

At least 2 approving reviews are required to merge this pull request.

Assignees

@AviadP AviadP

@amr1ta amr1ta

Labels
lgtm size/M PR that changes 30-99 lines Squad/Brown Verified Mark when PR was verified and log provided
Projects
None yet
Milestone
No milestone
5 participants
@yitzhak12 @ebenahar @AviadP @amr1ta @ocs-ci