[GSS] Test if MCG secrets are used in env variables and bucketclass can be modified #10943
Conversation
Signed-off-by: Mahesh Shetty <[email protected]>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: mashetty330 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
mashetty330
added
team/e2e
Signed-off-by: Mahesh Shetty <[email protected]>
pull-request-size
bot
added
size/L
mashetty330
changed the title
| env["name"].split("_")[0] != "POSTGRES" | ||
| and env["name"].split("_")[0] != "POSTGRESQL" | ||
| ) and ("valueFrom" in env and "secretKeyRef" in env["valueFrom"]): | ||
| logger.info(env) |
There was a problem hiding this comment.
Let's add a bit more context to make our analysis easier in case such an env var does gets added in the future:
| logger.info(env) | |
| logger.warn(f'Non-psql secret is referenced in the noobaa-app under env var: {env}') |
| f' {{"op": "replace", "path": "/spec/placementPolicy/tiers/0/placement", "value": "Mirror"}}]', | ||
| format_type="json", | ||
| ) | ||
|
|
There was a problem hiding this comment.
It might not be in the reproduction steps in the original BZ, but please also check that the original bucket is still usable after updating the Bucketclass.
Repeating write_random_test_objects_to_bucket on it should be enough.
| obc_obj.patch( | ||
| params=f'[{{"op": "add", "path": "/spec/placementPolicy/tiers/0/backingStores/-", ' | ||
| f'"value": "{backingstore.name}"}},' | ||
| f' {{"op": "replace", "path": "/spec/placementPolicy/tiers/0/placement", "value": "Mirror"}}]', | ||
| format_type="json", | ||
| ) |
There was a problem hiding this comment.
Does the change take place immediately? Please verify, ideally with a retry/Timeoutsampler, that the change was not reconciled and that the Bucketclass is ready after this patch operation.
|
|
||
| class TestBucketClass: |
There was a problem hiding this comment.
Add the mcg and red_squad decorators to fix the PR checks
Addresses:
https://bugzilla.redhat.com/show_bug.cgi?id=2152143
https://bugzilla.redhat.com/show_bug.cgi?id=2272084