Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spell fixes in the README #33

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Spell fixes in the README #33

wants to merge 2 commits into from

Conversation

brint
Copy link

@brint brint commented Apr 10, 2017

  • Addresses spelling errors in the readme
  • Makes the use of "Redbooth" with a capital "R" consistent through the doc

@brint
Copy link
Author

brint commented Apr 10, 2017

Added a commit to bump the tested versions of Ruby to currently supported versions. The ones in .travis.yml (2.0, 2.1) are EOL. Bumping to 2.3 and 2.4 to see if tests will pass. The error on the previous test was as follows:

rack-2.0.1 requires ruby version >= 2.2.2, which is incompatible with the current version, ruby 2.0.0p648

@brint
Copy link
Author

brint commented Apr 10, 2017

The newest failure is due to a change in how code climate now works. I implemented this fix locally, docs are here:

https://docs.codeclimate.com/docs/test-coverage-ruby

However this lead to 185 failures

Finished in 4.41 seconds (files took 0.61539 seconds to load)
327 examples, 185 failures

Most failures are around this since it looks like there isn't a step to :

Failed to open TCP connection to localhost:3000 (Connection refused - connect(2) for "localhost" port 3000)

It looks like there are some other errors in the client that may be related to how newer versions of Ruby and various gems work. For example:

  44) RedboothRuby::File.create makes a new POST request using the correct API endpoint to create a specific file
      Failure/Error:
        http.start do |inner_http|
          inner_http.request(req)
        end
      
      NoMethodError:
        undefined method `close' for #<StubSocket:0x007fcc5a292790>
        Did you mean?  closed?
                       clone
      # ./lib/redbooth-ruby/request/connection.rb:127:in `block in multipart_request'
      # ./lib/redbooth-ruby/request/connection.rb:103:in `open'
      # ./lib/redbooth-ruby/request/connection.rb:103:in `multipart_request'
      # ./lib/redbooth-ruby/request/connection.rb:20:in `request'
      # ./lib/redbooth-ruby/request/base.rb:29:in `send_request'
      # ./lib/redbooth-ruby/request/base.rb:14:in `perform'
      # ./lib/redbooth-ruby.rb:114:in `request'
      # ./lib/redbooth-ruby/operations/create.rb:10:in `create'
      # ./lib/redbooth-ruby/file.rb:42:in `create'
      # ./lib/redbooth-ruby/client_operations/perform.rb:22:in `perform!'
      # ./lib/redbooth-ruby/client.rb:56:in `perform!'
      # (eval):3:in `file'
      # ./spec/redbooth-ruby/file_spec.rb:11:in `block (2 levels) in <top (required)>'
      # ./spec/redbooth-ruby/file_spec.rb:53:in `block (3 levels) in <top (required)>'
      # ./spec/redbooth-ruby/file_spec.rb:60:in `block (3 levels) in <top (required)>'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant